Upgrade vcpkg dependencies for the missed boost-format dependency #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Motivation See microsoft/vcpkg#36510 Currently the commit id of the vcpkg submodule is old. With latest dependencies in vcpkg, it requires a `boost-format` dependency to build. ### Modifications Upgrade the vcpkg submodule to the latest commit at the moment and add the `boost-format` dependency to fix the build.
merlimat
approved these changes
Jun 11, 2024
|
There are some failed tests. I'm going to check if they were introduced by an upgraded dependency |
|
It's an issue with the JSON serialization for key-value schema. Maybe caused by the |
|
The root cause is that latest's Boost.PropertyTree does not write a line ending in |
|
There is a bug for GCC 4.8 that it does not support I sent an email to drop GCC 4.8 in the next release (see https://lists.apache.org/thread/7o8hpv1gtoffvzx053wm0ss2s9xt0795), so I will open a PR to drop the support for GCC 4.8 first and then go back to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See microsoft/vcpkg#36510
Currently the commit id of the vcpkg submodule is old. With latest dependencies in vcpkg, it requires a
boost-formatdependency to build.Modifications
Upgrade the vcpkg submodule to the latest commit at the moment and add the
boost-formatdependency to fix the build.