GH-3029: Fix EncryptionPropertiesHelper not to use java.nio.file.Path #3038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gszadovszky Could you help review this? Thanks! |
gszadovszky
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
EncryptionPropertiesHelper has been changed to use java.nio.file.Path but the
file:URI will fail on Windows.See #3029 for detail.
What changes are included in this PR?
Change EncryptionPropertiesHelper not to use java.nio.file.Path.
Are these changes tested?
Pass CI.
Are there any user-facing changes?
No
Closes #3029