Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] The record level expired time field type is automatically recognized. #4458

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

zhuangchong
Copy link
Contributor

Purpose

The record level expired time field type is automatically recognized.

The user is not required to enter the field type record-level.time-field-type, and the input may be incorrect.

Tests

API and Format

Documentation

Copy link
Contributor

@wwj6591812 wwj6591812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good Job.

+1

.withDescription(
"Time field type for record level expire, it can be seconds-int,seconds-long, millis-long or timestamp.");
"Time field for record level expire. It supports the following types: `timestamps in seconds with INT`,`timestamps in seconds with BIGINT`, `Timestamps in milliseconds with BIGINT` or `Timestamp`.");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

timestamps in milliseconds with BIGINT or timestamp

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@askwang
Copy link
Contributor

askwang commented Nov 6, 2024

+1, nice job

@JingsongLi
Copy link
Contributor

Thanks @zhuangchong , Nice job!

Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JingsongLi JingsongLi merged commit b4601f3 into apache:master Nov 6, 2024
13 checks passed
@zhuangchong zhuangchong deleted the record-level-fieldtype-auto branch November 6, 2024 05:54
hang8929201 pushed a commit to hang8929201/paimon that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants