[core] Allow cache and refresh partitions for CachingCatalog #4427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JingsongLi
requested changes
Nov 1, 2024
wwj6591812
reviewed
Nov 3, 2024
paimon-core/src/main/java/org/apache/paimon/catalog/CachingCatalog.java
Outdated
Show resolved
Hide resolved
paimon-common/src/main/java/org/apache/paimon/options/CatalogOptions.java
Outdated
Show resolved
Hide resolved
| return ((FileStoreTable) table).newSnapshotReader().partitionEntries(); | ||
| } | ||
|
|
||
| public List<PartitionEntry> refreshPartitions(Identifier identifier) |
There was a problem hiding this comment.
Other engines may call this method regularly, so it should be public.
paimon-core/src/main/java/org/apache/paimon/catalog/CachingCatalog.java
Outdated
Show resolved
Hide resolved
paimon-core/src/main/java/org/apache/paimon/catalog/CachingCatalog.java
Outdated
Show resolved
Hide resolved
| if (enablePartitionCache(table) | ||
| && partitionCache.asMap().values().stream().mapToInt(List::size).sum() | ||
| < this.partitionMaxNum) { | ||
| partitionCache.put(identifier, partitions); |
There was a problem hiding this comment.
After this put, if the total cached partitions in partitionCache is larger than partitionMaxNum. How do you handle this situation?
There was a problem hiding this comment.
No more partitions will be put in util some are expired, I suppose it tolerable.
| throws TableNotExistException, PartitionNotExistException { | ||
| wrapped.dropPartition(identifier, partitions); | ||
| if (partitionCache != null) { | ||
| partitionCache.invalidate(identifier); |
There was a problem hiding this comment.
Why invalidate all partitions of this identifier in the cache?
There was a problem hiding this comment.
Can't find a better way, any ideas?
paimon-core/src/test/java/org/apache/paimon/catalog/CachingCatalogTest.java
Outdated
Show resolved
Hide resolved
paimon-core/src/test/java/org/apache/paimon/catalog/CachingCatalogTest.java
Outdated
Show resolved
Hide resolved
paimon-core/src/test/java/org/apache/paimon/catalog/CachingCatalogTest.java
Outdated
Show resolved
Hide resolved
JingsongLi
reviewed
Nov 4, 2024
JingsongLi
reviewed
Nov 4, 2024
paimon-core/src/main/java/org/apache/paimon/catalog/CachingCatalog.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #4205
Tests
testPartitionCache
API and Format
CachingCatalog.getPartitions
CachingCatalog.refreshPartitions
Documentation
Allow cache and refresh partitions for CachingCatalog.