-
Notifications
You must be signed in to change notification settings - Fork 946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Introduce withReadType in ReadBuilder #4214
Merged
JingsongLi
merged 10 commits into
apache:master
from
Zouxxyy:variant/withRowTypeProjection
Sep 25, 2024
Merged
[core] Introduce withReadType in ReadBuilder #4214
JingsongLi
merged 10 commits into
apache:master
from
Zouxxyy:variant/withRowTypeProjection
Sep 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zouxxyy
force-pushed
the
variant/withRowTypeProjection
branch
from
September 19, 2024 05:11
d587353
to
3259d18
Compare
We just need a |
RowType contains all the information (field name, field id, nested structure ... ), it can replace projection The final API will be modified to like this @Deprecated
default ReadBuilder withProjection(int[] projection) {
// projection -> requiredSchema
return pruneColumns(RowType requiredSchema);
}
ReadBuilder pruneColumns(RowType requiredSchema); |
Zouxxyy
force-pushed
the
variant/withRowTypeProjection
branch
from
September 22, 2024 10:48
e2339eb
to
2102046
Compare
Zouxxyy
changed the title
[WIP] Introduce RowTypeProjection for ReadBuilder
[core] Introduce withReadType in ReadBuilder
Sep 22, 2024
Zouxxyy
force-pushed
the
variant/withRowTypeProjection
branch
from
September 23, 2024 09:20
2102046
to
f14be50
Compare
JingsongLi
reviewed
Sep 24, 2024
JingsongLi
reviewed
Sep 24, 2024
paimon-common/src/main/java/org/apache/paimon/types/RowType.java
Outdated
Show resolved
Hide resolved
JingsongLi
reviewed
Sep 24, 2024
paimon-common/src/main/java/org/apache/paimon/types/DataType.java
Outdated
Show resolved
Hide resolved
JingsongLi
reviewed
Sep 24, 2024
paimon-common/src/main/java/org/apache/paimon/types/RowType.java
Outdated
Show resolved
Hide resolved
JingsongLi
reviewed
Sep 24, 2024
paimon-common/src/main/java/org/apache/paimon/types/RowType.java
Outdated
Show resolved
Hide resolved
JingsongLi
reviewed
Sep 24, 2024
paimon-common/src/main/java/org/apache/paimon/types/RowType.java
Outdated
Show resolved
Hide resolved
JingsongLi
reviewed
Sep 24, 2024
paimon-common/src/main/java/org/apache/paimon/types/RowType.java
Outdated
Show resolved
Hide resolved
JingsongLi
reviewed
Sep 24, 2024
paimon-common/src/main/java/org/apache/paimon/types/RowType.java
Outdated
Show resolved
Hide resolved
Zouxxyy
force-pushed
the
variant/withRowTypeProjection
branch
from
September 24, 2024 03:53
8dd3634
to
ddb6b42
Compare
@JingsongLi Thanks for review, updated |
JingsongLi
reviewed
Sep 24, 2024
paimon-common/src/main/java/org/apache/paimon/types/DataType.java
Outdated
Show resolved
Hide resolved
paimon-core/src/main/java/org/apache/paimon/io/KeyValueFileReaderFactory.java
Outdated
Show resolved
Hide resolved
paimon-core/src/main/java/org/apache/paimon/table/source/ReadBuilder.java
Show resolved
Hide resolved
JingsongLi
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
To #4209
public API
mark
ReadBuilder withProjection(int[][] projection)
andReadBuilder withProjection(int[] projection)
asDeprecated
how to use