Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core]Fix branchesTable created_from_snapshot field display result error. #4159

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

herefree
Copy link
Contributor

@herefree herefree commented Sep 10, 2024

Purpose

created_from_snapshot should be the origin of the tag,not the earliest snapshot of the branch.

Linked issue: close #xxx

Tests

API and Format

Documentation

@LinMingQiang
Copy link
Contributor

It is possible that the branches tag does not exist but the snapshot exists?

@herefree
Copy link
Contributor Author

It is possible that the branches tag does not exist but the snapshot exists?

Yes, if you create empty branch then insert some data to this branch, or you create branch from tag then delete branch's tag. In above two case snapshot will exists,tag will not exists. In this case created_from_tag will be null.
I do not think we should remain created_from_snapshot,because we only support create_branch from tag. Snapshot will expire quickly, it's hard for us to know whether the earliest snapshot of the branch is from the main branch.

@LinMingQiang
Copy link
Contributor

created_from_snapshot can be the origin of the tag?

@herefree
Copy link
Contributor Author

created_from_snapshot can be the origin of the tag?

That's okay, I'll modify it.

@herefree herefree changed the title [core]Remove created_from_snapshot field from BranchesTable [core]Fix branchesTable created_from_snapshot field display result error. Sep 10, 2024
@LinMingQiang
Copy link
Contributor

With the current architecture, we cannot accurately obtain the origin snapshot of the branch. Maybe we should open a discussion thread to discuss this issue.

@herefree
Copy link
Contributor Author

With the current architecture, we cannot accurately obtain the origin snapshot of the branch. Maybe we should open a discussion thread to discuss this issue.

I create a issue #4166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants