[core] Remove file io from splits and Add preferFileIO for Paimon catalog. #2995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leaves12138
force-pushed
the
removefileiofromsnapshot
branch
from
781e11f
to
2c308a2
Compare
leaves12138
changed the title
JingsongLi
reviewed
Mar 13, 2024
paimon-common/src/main/java/org/apache/paimon/catalog/CatalogContext.java
Outdated
Show resolved
Hide resolved
JingsongLi
reviewed
Mar 13, 2024
JingsongLi
reviewed
Mar 13, 2024
paimon-core/src/main/java/org/apache/paimon/table/source/DataFilePlan.java
Outdated
Show resolved
Hide resolved
JingsongLi
reviewed
Mar 13, 2024
paimon-core/src/main/java/org/apache/paimon/table/source/SimplePlan.java
Outdated
Show resolved
Hide resolved
JingsongLi
reviewed
Mar 13, 2024
| @@ -129,17 +133,17 @@ private static class AggregationSplit implements Split { | |||
|
|
|||
| private static final long serialVersionUID = 1L; | |||
|
|
|||
| private final FileIO fileIO; | |||
There was a problem hiding this comment.
Can you add a test to verify no fileIO here?
added 2 commits
March 13, 2024 13:47
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason:
FileIO, because compute system file io (which wrapped as paimon file io) may not be able to serialized.preferFileIOfor testing wrapped file io by compute system (like trino).