[core] Introduce deletion files to DataSplit #2988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JingsongLi
force-pushed
the
split_deletion_files
branch
from
b11e473
to
08b2114
Compare
Zouxxyy
reviewed
Mar 12, 2024
paimon-core/src/main/java/org/apache/paimon/table/source/DeletionFile.java
Show resolved
Hide resolved
| file.schemaId(), fileName, file.fileSize(), file.level()); | ||
| if (deletionFile != null) { | ||
| DeletionVector deletionVector = | ||
| DeletionVector.read(fileIO, deletionFile); |
There was a problem hiding this comment.
Maybe can add this to IndexFileHandler, readDeletionVector contains version and crc verification
public DeletionVector readDeletionVector(DeletionFile deletionFile) {
return deletionVectorsIndex.readDeletionVector(
new Path(deletionFile.path()),
Pair.of(deletionFile.offset(), deletionFile.length()));
}
There was a problem hiding this comment.
I don't want introduce IndexFileHandler here, imagine a C++Reader, which should not rely on any complex classes, the simpler the better.
| if (deletionFile != null) { | ||
| DeletionVector deletionVector = | ||
| DeletionVector.read(fileIO, deletionFile); | ||
| reader = ApplyDeletionVectorReader.create(reader, deletionVector); |
There was a problem hiding this comment.
Worry about conflicts with readerFactoryBuilder.withDeletionVectorSupplier in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Deletion file should be in Split, and the reader should respect deletion files in Split, instead of reading deletion manifest again which is very costly.
Tests
API and Format
Documentation