Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hive] Drop a Hive external table only deletes metadata but not data files. #2979

Merged
merged 4 commits into from
Mar 12, 2024

Conversation

zhuangchong
Copy link
Contributor

Purpose

1.Drop a Hive external table only deletes metadata but not data files.
2.Remove uncalled methods: checkIdentifierUpperCase、schemaFileExists
3.Modify wrong words

Tests

API and Format

Documentation

@@ -27,7 +27,7 @@ public final class JdbcCatalogOptions {
public static final ConfigOption<String> CATALOG_KEY =
ConfigOptions.key("catalog-key")
.stringType()
.defaultValue(null)
.defaultValue("jdbc")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modify documentation too

Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JingsongLi JingsongLi merged commit 58113a7 into apache:master Mar 12, 2024
10 checks passed
@zhuangchong zhuangchong deleted the hive-external-table-drop branch March 12, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants