Skip to content

Commit

Permalink
fix
Browse files Browse the repository at this point in the history
  • Loading branch information
JingsongLi committed Sep 18, 2024
1 parent 30e0292 commit 31ea0f3
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -177,8 +177,7 @@ public StatsFileHandler newStatsFileHandler() {
new StatsFile(fileIO, pathFactory().statsFileFactory()));
}

@Override
public ManifestsReader newManifestPlanner(boolean forWrite) {
protected ManifestsReader newManifestsReader(boolean forWrite) {
return new ManifestsReader(partitionType, snapshotManager(), manifestListFactory(forWrite));
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ public void pushdown(Predicate predicate) {
};

return new AppendOnlyFileStoreScan(
newManifestPlanner(forWrite),
newManifestsReader(forWrite),
partitionType,
bucketFilter,
snapshotManager(),
Expand Down
7 changes: 0 additions & 7 deletions paimon-core/src/main/java/org/apache/paimon/FileStore.java
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
import org.apache.paimon.operation.FileStoreCommit;
import org.apache.paimon.operation.FileStoreScan;
import org.apache.paimon.operation.FileStoreWrite;
import org.apache.paimon.operation.ManifestsReader;
import org.apache.paimon.operation.PartitionExpire;
import org.apache.paimon.operation.SnapshotDeletion;
import org.apache.paimon.operation.SplitRead;
Expand Down Expand Up @@ -66,12 +65,6 @@ public interface FileStore<T> {

BucketMode bucketMode();

default ManifestsReader newManifestPlanner() {
return newManifestPlanner(false);
}

ManifestsReader newManifestPlanner(boolean forWrite);

FileStoreScan newScan();

ManifestList.Factory manifestListFactory();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ public void pushdown(Predicate keyFilter) {
}
};
return new KeyValueFileStoreScan(
newManifestPlanner(forWrite),
newManifestsReader(forWrite),
partitionType,
bucketFilter,
snapshotManager(),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,8 @@ public BucketMode bucketMode() {
}

@Override
public ManifestsReader newManifestPlanner(boolean forWrite) {
return wrapped.newManifestPlanner(forWrite);
public ManifestsReader newManifestsReader(boolean forWrite) {
return wrapped.newManifestsReader(forWrite);
}

@Override
Expand Down

0 comments on commit 31ea0f3

Please sign in to comment.