Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORC-1264: [C++] Add a writer option to align compression block with row group #2005

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

luffy-zh
Copy link
Contributor

@luffy-zh luffy-zh commented Aug 16, 2024

What changes were proposed in this pull request?

Add support for the ORC writer to ensure that the compression block is aligned with the row group boundary。

Why are the changes needed?

To reduce unnecessary I/O and decompression when PPD is in effect, we can enforce the compression block to be aligned with the row group boundary. For more detail, see link

How was this patch tested?

Uts in TestWriter.cc can convert this patch.

Was this patch authored or co-authored using generative AI tooling?

NO

@github-actions github-actions bot added the CPP label Aug 16, 2024
c++/include/orc/Reader.hh Outdated Show resolved Hide resolved
c++/include/orc/Reader.hh Outdated Show resolved Hide resolved
c++/include/orc/Writer.hh Show resolved Hide resolved
c++/include/orc/Reader.hh Outdated Show resolved Hide resolved
c++/src/ColumnWriter.cc Outdated Show resolved Hide resolved
c++/src/ColumnWriter.cc Show resolved Hide resolved
c++/test/TestWriter.cc Show resolved Hide resolved
@wgtmac wgtmac changed the title ORC-1264: [C++] Add a writer option to align compression block with r… ORC-1264: [C++] Add a writer option to align compression block with row group Aug 29, 2024
@luffy-zh luffy-zh requested a review from wgtmac August 29, 2024 08:30
Copy link
Member

@wgtmac wgtmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM.

c++/src/ColumnWriter.hh Outdated Show resolved Hide resolved
c++/include/orc/Reader.hh Outdated Show resolved Hide resolved
c++/include/orc/Reader.hh Outdated Show resolved Hide resolved
@dongjoon-hyun dongjoon-hyun added this to the 2.1.0 milestone Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants