Add path param support #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessealva
force-pushed
the
add-path-param-support
branch
from
578954f
to
4943986
Compare
|
@mdeuser could you review this real quick? its a change to enable parameters as children of Paths |
|
@jessealva, can we unit test this? |
mdeuser
reviewed
Jan 10, 2018
whisk/api.go
Outdated
| @@ -146,13 +146,51 @@ type ApiSwagger struct { | |||
| SwaggerName string `json:"swagger,omitempty"` | |||
| BasePath string `json:"basePath,omitempty"` | |||
| Info *ApiSwaggerInfo `json:"info,omitempty"` | |||
| Paths map[string]map[string]*ApiSwaggerOperation `json:"paths,omitempty"` // Paths["/a/path"]["get"] -> a generic object | |||
| Paths map[string]*ApiSwaggerPath `json:"paths,omitempty"` // Paths["/a/path"]["get"] -> a generic object | |||
There was a problem hiding this comment.
i think the comment is incorrect. should be something like
// Paths["/a/path"] -> a path (ApiSwaggerPath) object
There was a problem hiding this comment.
Removing the comment as I think its no longer required as it was there when the object was a map of maps.
…as the object is no longer a map of maps
jessealva
force-pushed
the
add-path-param-support
branch
from
4943986
to
7c36676
Compare
dubee
approved these changes
Jan 19, 2018
|
@jessealva, looks great! Do you have tests for this at least in incubator-openwhisk-cli? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.