Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env and env-file flags for action create/update #523

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

giusdp
Copy link
Member

@giusdp giusdp commented Apr 22, 2023

Following the PR that adds the Env field to the action struct in client-go apache/openwhisk-client-go#158, this PR adds the --env and --env-file flag to wsk action create/update.

It follows closely the code for the --params and --annotation flags to add support for passing environment variables during action initialization.

I tried to extend some tests in Go but let me know where I should add more.

I've also updated the client-go dep to the latest commit and run go mod tidy which removed many deps.

@kcexn
Copy link

kcexn commented Nov 30, 2023

Can you explain to me how the environment variables are passed to the action initialization route in the action-proxy?

I thought the OpenWhisk-CLI simply sends requests to the OpenWhisk API? And as far as I can tell, the OpenWhisk API does not directly support passing environment variables to actions on initialization. Unless there is an undocumented annotation for it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants