Added test cases for quoted strings. #173
Conversation
|
@drcariel would you like to review this guy and see what you think? Looks like this failed cause i have dependencies on apache/openwhisk#3045 changes that this obviously doesnt have yet...making a change over there |
jessealva
force-pushed
the
fix-164-add-quote-tests
branch
from
e8cfa2e to
725f48e
Compare
jessealva
force-pushed
the
fix-164-add-quote-tests
branch
from
725f48e to
4316996
Compare
jessealva
force-pushed
the
fix-164-add-quote-tests
branch
from
92a8ff2 to
3b320e1
Compare
| @@ -82,6 +84,76 @@ class WskSdkTests extends TestHelpers with WskTestHelpers { | |||
| } | |||
| } | |||
|
|
|||
| it should "download docker sdk when blackbox.tar.gz exists, and docker name should be quoted in error." in { | |||
There was a problem hiding this comment.
Could use Seq to squash this test and "download ios sdk when OpenWhiskIOSStarterApp.zip exists, and ios name should be quoted in error. into one test.
| } | ||
| } | ||
|
|
||
| it should "download ios sdk, check filename is quoted in error when create fails." in { |
There was a problem hiding this comment.
Can we expect the same directory permission issue with the Docker SDK?
$ mkdir wskinstall
$ chmod 555 wskinstall
$ cd wskinstall
$ wsk sdk install docker
error: The docker SDK installation failed: Error creating SDK file 'blackbox.tar.gz': open blackbox.tar.gz: permission denied
Could test both with Seq.
There was a problem hiding this comment.
I'll have to double check this one but last i checked i think there was no way to inject the bad permissions between the download and extraction.
|
@jessealva please take a look at the issue: #221 Travis build is not happy at this moment, due to async with openwhisk. |
|
@dubee this needs a rebase --- is this something you can do? otherwise going to close this. |
These are some missing tests for apache/openwhisk#2462. Not all strings are reachable...some are in debug messages and there is no facility for enabling debugging in the cli in tests right now.
Also some of these are not reachable as there is no way for me to force a break of the code as the messages are embedded in an automated sdk install portion of the code.
I added as many tests as I could based on what was reachable via the testing framework.