Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add codspeed for benchmark #5280

Merged
merged 16 commits into from
Nov 4, 2024
Merged

chore: add codspeed for benchmark #5280

merged 16 commits into from
Nov 4, 2024

Conversation

dqhl76
Copy link
Member

@dqhl76 dqhl76 commented Nov 4, 2024

Which issue does this PR close?

Closes #4937 .

Rationale for this change

What changes are included in this PR?

A new workflow that runs on every PR and the default main branch.
The criterion dependency is changed to codspeed-criterion-compat.
This should not affect cargo bench

Are there any user-facing changes?

@Xuanwo
Copy link
Member

Xuanwo commented Nov 4, 2024

Hi, @dqhl76, token has been created at op://services/codspeed/token.

Copy link

codspeed-hq bot commented Nov 4, 2024

CodSpeed Performance Report

Congrats! CodSpeed is installed 🎉

🆕 73 new benchmarks were detected.

You will start to see performance impacts in the reports once the benchmarks are run from your default branch.

Detected benchmarks

  • 16.0 MiB (8.5 ms)
  • 256 KiB (192.2 µs)
  • 4.00 KiB (62.3 µs)
  • 4.00 MiB (2.2 ms)
  • 16x16.0 MiB (236.9 µs)
  • 16x256 KiB (237.2 µs)
  • 16x4.00 KiB (234.6 µs)
  • 16x4.00 MiB (237.4 µs)
  • 1x16.0 MiB (54.5 µs)
  • 1x256 KiB (54.7 µs)
  • 1x4.00 KiB (54.6 µs)
  • 1x4.00 MiB (54.6 µs)
  • 2x16.0 MiB (66.9 µs)
  • 2x256 KiB (67.2 µs)
  • 2x4.00 KiB (66.7 µs)
  • 2x4.00 MiB (67 µs)
  • 4x16.0 MiB (91.5 µs)
  • 4x256 KiB (91.6 µs)
  • 4x4.00 KiB (90.2 µs)
  • 4x4.00 MiB (91.8 µs)
  • 8x16.0 MiB (141.2 µs)
  • 8x256 KiB (140 µs)
  • 8x4.00 KiB (139.2 µs)
  • 8x4.00 MiB (140.7 µs)
  • 16.0 MiB (57 µs)
  • 256 KiB (56.7 µs)
  • 4.00 KiB (56.7 µs)
  • 4.00 MiB (56.8 µs)
  • 1 (91.6 µs)
  • 2 (91.8 µs)
  • 4 (91.9 µs)
  • 8 (92 µs)
  • buffer 256 KiB * 32 advance (660.6 ns)
  • buffer 256 KiB * 32 chunk (212.8 ns)
  • buffer 256 KiB * 32 truncate (375.3 ns)
  • buffer 256 KiB * 4 advance (660.6 ns)
  • buffer 256 KiB * 4 chunk (183.6 ns)
  • buffer 256 KiB * 4 truncate (375.3 ns)
  • buffer 4.00 MiB * 32 advance (660.6 ns)
  • buffer 4.00 MiB * 32 chunk (183.6 ns)
  • buffer 4.00 MiB * 32 truncate (375.3 ns)
  • buffer 4.00 MiB * 4 advance (660.6 ns)
  • buffer 4.00 MiB * 4 chunk (183.6 ns)
  • buffer 4.00 MiB * 4 truncate (375.3 ns)
  • bytes buf 256 KiB * 32 advance (493.3 ns)
  • bytes buf 256 KiB * 32 chunk (0 s)
  • bytes buf 256 KiB * 32 truncate (552.8 ns)
  • bytes buf 256 KiB * 4 advance (493.3 ns)
  • bytes buf 256 KiB * 4 chunk (0 s)
  • bytes buf 256 KiB * 4 truncate (552.8 ns)
  • bytes buf 4.00 MiB * 32 advance (493.3 ns)
  • bytes buf 4.00 MiB * 32 chunk (0 s)
  • bytes buf 4.00 MiB * 32 truncate (552.8 ns)
  • bytes buf 4.00 MiB * 4 advance (493.3 ns)
  • bytes buf 4.00 MiB * 4 chunk (0 s)
  • bytes buf 4.00 MiB * 4 truncate (552.8 ns)
  • 256 KiB * 1000k advance (17.4 ms)
  • 256 KiB * 1000k chunk (154.4 ns)
  • 256 KiB * 1000k truncate (216.7 ns)
  • 256 KiB * 100k advance (1.7 ms)
  • 256 KiB * 100k chunk (154.4 ns)
  • 256 KiB * 100k truncate (216.7 ns)
  • 256 KiB * 10k advance (174.1 µs)
  • 256 KiB * 10k chunk (183.6 ns)
  • 256 KiB * 10k truncate (216.7 ns)
  • 256 KiB * 1k advance (17.9 µs)
  • 256 KiB * 1k chunk (154.4 ns)
  • 256 KiB * 1k truncate (216.7 ns)
  • concurrent 1 (268.8 µs)
  • concurrent 16 (324.6 µs)
  • concurrent 2 (530.1 µs)
  • concurrent 4 (419.1 µs)
  • concurrent 8 (361.4 µs)

@Xuanwo
Copy link
Member

Xuanwo commented Nov 4, 2024

The benchmark is identified by name, and we can expand it to support various services. We can implement this in future PRs.

@dqhl76 dqhl76 marked this pull request as ready for review November 4, 2024 11:55
@dqhl76 dqhl76 requested a review from PsiACE as a code owner November 4, 2024 11:55
@dqhl76
Copy link
Member Author

dqhl76 commented Nov 4, 2024

Hi @Xuanwo, All comments are applied, could you please take a look again? Thanks!

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @dqhl76, for working on this. Also, thank you, @adriencaccia, for building this great service and helping us with the integration.

@Xuanwo Xuanwo merged commit 71c12a3 into main Nov 4, 2024
80 checks passed
@Xuanwo Xuanwo deleted the benchmark-ci branch November 4, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new feature: Add CodSpeed for benchmark
2 participants