Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(core): Fix comment for into_futures_async_write #4928

Merged
merged 1 commit into from
Jul 26, 2024
Merged

docs(core): Fix comment for into_futures_async_write #4928

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions core/src/types/write/writer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,9 +186,8 @@ impl Writer {
/// FuturesAsyncWriter is not a zero-cost abstraction. The underlying writer
/// requires an owned [`Buffer`], which involves an extra copy operation.
///
/// FuturesAsyncWriters are automatically closed when they go out of scope. Errors detected on
/// closing are ignored by the implementation of Drop. Use the method `close` if these errors
/// must be manually handled.
/// FuturesAsyncWriter is required to call `close()` to make sure all
/// data have been written to the storage.
///
/// # Examples
///
Expand Down
Loading