-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(services/compfs): basic Access
impl
#4693
Conversation
Access
implAccess
impl for services-compfs
Access
impl for services-compfs
Access
impl for services-compfs
Access
impl for services-compfs
Access
impl
45ee5c6
to
791bb95
Compare
Access
implAccess
impl
1ded7fd
to
1a3bf7c
Compare
cc @George-Miao, would you like to submit a PR to bump |
Sure. Will do |
I have updated all |
1a3bf7c
to
c7b32c7
Compare
Hmmm.. compio doesn't support wasm so it won't compile under wasm. Besides that all CI's have passed. @Xuanwo |
Only few services are enabled under wasm target. Maybe we should make all compio related crates optional? |
Oh I see. I didn't mark driver as optional. I'll change that later. Do you think it's ok to release new version for compio? After that we can merge this PR. |
Looks nice to me so far. Let's cut a new version for compio 🤩 |
c7b32c7
to
72a96c5
Compare
3bbb253
to
ce40456
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks!
This PR implements basic function of
Access
forCompfs
, includeCompfsReader
,CompfsWriter
andCompfsLister
.For now, this branch uses git dependency ofcompio
to test the lastest updates. Before merging, compio should make a new release (by @George-Miao, me) and update the correspondingCargo.toml
entry.New release has been made and updated. Ready to be merged.