Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(services/compfs): basic Access impl #4693

Merged
merged 6 commits into from
Jun 19, 2024
Merged

Conversation

George-Miao
Copy link
Contributor

@George-Miao George-Miao commented Jun 5, 2024

This PR implements basic function of Access for Compfs, include CompfsReader, CompfsWriter and CompfsLister.

For now, this branch uses git dependency of compio to test the lastest updates. Before merging, compio should make a new release (by @George-Miao, me) and update the corresponding Cargo.toml entry.

New release has been made and updated. Ready to be merged.

@George-Miao George-Miao changed the title feat(services-compfs): baisc Access impl feat(core): baisc Access impl for services-compfs Jun 5, 2024
@George-Miao George-Miao changed the title feat(core): baisc Access impl for services-compfs feat(services/compfs): baisc Access impl for services-compfs Jun 5, 2024
@George-Miao George-Miao changed the title feat(services/compfs): baisc Access impl for services-compfs feat(services/compfs): baisc Access impl Jun 5, 2024
@George-Miao George-Miao force-pushed the compio-master branch 2 times, most recently from 45ee5c6 to 791bb95 Compare June 5, 2024 16:04
@George-Miao George-Miao changed the title feat(services/compfs): baisc Access impl feat(services/compfs): basic Access impl Jun 5, 2024
@George-Miao George-Miao marked this pull request as ready for review June 5, 2024 16:50
@George-Miao George-Miao requested a review from Xuanwo as a code owner June 5, 2024 16:50
@Xuanwo
Copy link
Member

Xuanwo commented Jun 6, 2024

cc @George-Miao, would you like to submit a PR to bump socket2 for other bin crates?

@George-Miao
Copy link
Contributor Author

cc @George-Miao, would you like to submit a PR to bump socket2 for other bin crates?

Sure. Will do

@Xuanwo
Copy link
Member

Xuanwo commented Jun 7, 2024

Sure. Will do

I have updated all Cargo.lock, this PR should be able to build now.

@George-Miao
Copy link
Contributor Author

Hmmm.. compio doesn't support wasm so it won't compile under wasm. Besides that all CI's have passed. @Xuanwo

@Xuanwo
Copy link
Member

Xuanwo commented Jun 15, 2024

Hmmm.. compio doesn't support wasm so it won't compile under wasm.

Only few services are enabled under wasm target. Maybe we should make all compio related crates optional?

@George-Miao
Copy link
Contributor Author

Oh I see. I didn't mark driver as optional. I'll change that later.

Do you think it's ok to release new version for compio? After that we can merge this PR.

@Xuanwo
Copy link
Member

Xuanwo commented Jun 15, 2024

Do you think it's ok to release new version for compio?

Looks nice to me so far. Let's cut a new version for compio 🤩

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@Xuanwo Xuanwo merged commit 90eb5be into apache:main Jun 19, 2024
210 checks passed
@George-Miao George-Miao deleted the compio-master branch June 19, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants