-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat : Implementing config for part of services #4344
Conversation
Requesting a review of the PR. I have added the functionalities as I have understood from the described issue.
feat : Implement config for module in services
Please solve the CI problem ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your contribution, here are some suggestions for this PR. Wish you have fun here.
You can directly run cargo fmt under the core directory to format all files under it. Besides, you need to make clippy happy by fixing the warning emitted by |
@Ji-Xinyou Done. All checks have passed. I was new to Rust so it took some time for me to understand cargo tool functionalities |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Have implemented XxxConfig for /core/src/services/memory as per the issue Tracking issues of RFC-3197: Config #3240. Requesting review.