Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add with_default to OperatorBuilder #3738

Closed

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Dec 11, 2023

Added with_default to OperatorBuilder. It allows users to add layers before the default layers.

close #3737

@WenyXu WenyXu force-pushed the feat/operator-builder-with-default branch from ce71b88 to 97b2675 Compare December 11, 2023 06:30
@WenyXu
Copy link
Member Author

WenyXu commented Dec 11, 2023

Interesting, some tests seem unstable. https://github.com/apache/incubator-opendal/actions/runs/7163688905

@Xuanwo
Copy link
Member

Xuanwo commented Dec 11, 2023

I don't want to expose API like with_default to users. If you have strong request for this feature, you can wrap the Accessor with layers you want outsides and calling Operator::new().

@WenyXu
Copy link
Member Author

WenyXu commented Dec 11, 2023

#3737

Thanks, it works for me 🥺, I'm going to close the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is it possible to add a layer before the CompleteLayer?
2 participants