[WIP] Rewrite cpp binding by pimpl #3584
Conversation
| * @brief The mode of the entry | ||
| */ | ||
| enum class EntryMode { | ||
| kFile = 0, |
There was a problem hiding this comment.
Why we need to add a k prefix here?
There was a problem hiding this comment.
tag it as a enum，distinguish it from macro
There was a problem hiding this comment.
that totally makes sense for enum, but this in an enum class so it is namespaced which should be totally sufficient.
| const noexcept; | ||
|
|
||
| private: | ||
| struct Rep; |
There was a problem hiding this comment.
representative，it's a common cpp impl name
Signed-off-by: Jack Drogon <[email protected]>
Signed-off-by: Jack Drogon <[email protected]>
Signed-off-by: Jack Drogon <[email protected]>
Signed-off-by: Jack Drogon <[email protected]>
Signed-off-by: Jack Drogon <[email protected]>
Signed-off-by: Jack Drogon <[email protected]>
Signed-off-by: Jack Drogon <[email protected]>
Signed-off-by: Jack Drogon <[email protected]>
JackDrogon
force-pushed
the
refactor/rewrite_cpp_binding_by_pimpl
branch
from
625bf93
to
cf59ad8
Compare
|
Hi, @JackDrogon, thanks for your effort, are you still interested in working on this now? |
Sorry, I've been taking care of some personal business lately, so I should be free to continue starting next week. |
|
Closed as stale and inactive. Any future effort would require a significant rewrite of this patch. |
No description provided.