Remove as ref for buffer

Signed-off-by: Xuanwo <[email protected]>

core/src/raw/adapters/kv/backend.rs

@@ -252,7 +252,7 @@ impl<S: Adapter> oio::Write for KvWriter<S> {
     }
 
     async fn close(&mut self) -> Result<()> {
-        let buf = self.buffer.collect();
+        let buf = self.buffer.clone().collect();
         self.kv.set(&self.path, buf).await
     }
 
@@ -270,7 +270,7 @@ impl<S: Adapter> oio::BlockingWrite for KvWriter<S> {
     }
 
     fn close(&mut self) -> Result<()> {
-        let buf = self.buffer.collect();
+        let buf = self.buffer.clone().collect();
         self.kv.blocking_set(&self.path, buf)?;
         Ok(())
     }

core/src/services/cacache/backend.rs

@@ -122,14 +122,14 @@ impl kv::Adapter for Adapter {
     }
 
     async fn set(&self, path: &str, value: Buffer) -> Result<()> {
-        cacache::write(&self.datadir, path, value)
+        cacache::write(&self.datadir, path, value.to_vec())
             .await
             .map_err(parse_error)?;
         Ok(())
     }
 
     fn blocking_set(&self, path: &str, value: Buffer) -> Result<()> {
-        cacache::write_sync(&self.datadir, path, value).map_err(parse_error)?;
+        cacache::write_sync(&self.datadir, path, value.to_vec()).map_err(parse_error)?;
         Ok(())
     }
 

core/src/services/d1/backend.rs

@@ -334,7 +334,7 @@ impl kv::Adapter for Adapter {
                     DO UPDATE SET {value_field} = EXCLUDED.{value_field}",
         );
 
-        let params = vec![path.into(), value.as_ref().into()];
+        let params = vec![path.into(), value.to_vec().into()];
         let req = self.create_d1_query_request(&query, params)?;
 
         let resp = self.client.send(req).await?;

core/src/services/foundationdb/backend.rs

@@ -170,7 +170,7 @@ impl kv::Adapter for Adapter {
     async fn set(&self, path: &str, value: Buffer) -> Result<()> {
         let transaction = self.db.create_trx().expect("Unable to create transaction");
 
-        transaction.set(path.as_bytes(), value.as_ref());
+        transaction.set(path.as_bytes(), &value.to_vec());
 
         match transaction.commit().await {
             Ok(_) => Ok(()),

core/src/services/gridfs/backend.rs

@@ -268,7 +268,7 @@ impl kv::Adapter for Adapter {
         // set new file
         let mut upload_stream = bucket.open_upload_stream(path, None);
         upload_stream
-            .write_all(value.as_ref())
+            .write_all(&value.to_vec())
             .await
             .map_err(new_std_io_error)?;
         upload_stream.close().await.map_err(new_std_io_error)?;

core/src/services/memcached/backend.rs

@@ -241,7 +241,7 @@ impl kv::Adapter for Adapter {
 
         conn.set(
             &percent_encode_path(key),
-            value.as_ref(),
+            &value.to_vec(),
             // Set expiration to 0 if ttl not set.
             self.default_ttl
                 .map(|v| v.as_secs() as u32)

core/src/services/mysql/backend.rs

@@ -278,7 +278,7 @@ impl kv::Adapter for Adapter {
             statement,
             params! {
                 "path" => path,
-                "value" => value.as_ref(),
+                "value" => value.to_vec(),
             },
         )
         .await

core/src/services/persy/backend.rs

@@ -211,7 +211,7 @@ impl kv::Adapter for Adapter {
     fn blocking_set(&self, path: &str, value: Buffer) -> Result<()> {
         let mut tx = self.persy.begin().map_err(parse_error)?;
         let id = tx
-            .insert(&self.segment, value.as_ref())
+            .insert(&self.segment, &value.to_vec())
             .map_err(parse_error)?;
 
         tx.put::<String, persy::PersyId>(&self.index, path.to_string(), id)

core/src/services/postgresql/backend.rs

@@ -323,7 +323,7 @@ impl kv::Adapter for Adapter {
             .await
             .map_err(parse_postgre_error)?;
         let _ = connection
-            .query(&statement, &[&path, &value.as_ref()])
+            .query(&statement, &[&path, &value.to_vec()])
             .await
             .map_err(parse_postgre_error)?;
         Ok(())

core/src/services/redb/backend.rs

@@ -183,7 +183,7 @@ impl kv::Adapter for Adapter {
                 .map_err(parse_table_error)?;
 
             table
-                .insert(path, value.as_ref())
+                .insert(path, &*value.to_vec())
                 .map_err(parse_storage_error)?;
         }
 

core/src/services/redis/backend.rs

@@ -400,7 +400,7 @@ impl kv::Adapter for Adapter {
 
     async fn set(&self, key: &str, value: Buffer) -> Result<()> {
         let conn = self.conn().await?;
-        let value = value.as_ref();
+        let value = value.to_vec();
         match self.default_ttl {
             Some(ttl) => match conn {
                 RedisConnection::Normal(mut conn) => conn

core/src/services/rocksdb/backend.rs

@@ -150,7 +150,9 @@ impl kv::Adapter for Adapter {
     }
 
     fn blocking_set(&self, path: &str, value: Buffer) -> Result<()> {
-        self.db.put(path, value).map_err(parse_rocksdb_error)
+        self.db
+            .put(path, value.to_vec())
+            .map_err(parse_rocksdb_error)
     }
 
     async fn delete(&self, path: &str) -> Result<()> {

core/src/services/sqlite/backend.rs

@@ -311,7 +311,7 @@ impl kv::Adapter for Adapter {
         );
         let mut statement = conn.prepare(&query).map_err(parse_rusqlite_error)?;
         statement
-            .execute(params![path, value.as_ref()])
+            .execute(params![path, value.to_vec()])
             .map_err(parse_rusqlite_error)?;
         Ok(())
     }

core/src/services/surrealdb/backend.rs

@@ -366,7 +366,7 @@ impl kv::Adapter for Adapter {
             .await?
             .query(query)
             .bind(("path", path))
-            .bind(("value", value.as_ref()))
+            .bind(("value", value.to_vec()))
             .await
             .map_err(parse_surrealdb_error)?;
         Ok(())

core/src/types/buffer.rs

@@ -148,13 +148,6 @@ impl Default for Buffer {
         Self::new()
     }
 }
-
-impl AsRef<[u8]> for Buffer {
-    fn as_ref(&self) -> &[u8] {
-        self.chunk()
-    }
-}
-
 impl Buffer {
     /// Create a new empty buffer.
     ///