Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable SYSLOG_DEFAULT by default #14695

Closed
wants to merge 1 commit into from

Commits on Nov 8, 2024

  1. Disable SYSLOG_DEFAULT by default

    Because the implementation is problematic.
    See apache#14662 for the discussion.
    Also, make it depend on EXPERIMENTAL to discourage it.
    
    Instead, enable SYSLOG_CONSOLE for a bit more cases.
    
    An alternative would be to introduce/extend some serialization
    mechanism (eg. enter_critical_section, which is currently used by
    the serial driver to interact with interrupts) to cover up_putc
    users including SYSLOG_DEFAULT. While it works, it doesn't sound
    attractive to me to introduce this kind of complexity to up_putc,
    which is supposed to be a very low-level machinary used early in
    the boot. Also, the implementation of such serialization can be
    complex because how up_putc works is basically device-specific and
    how it corresponds to other devices on the system (eg. uarts) isn't
    obvious to the upper layers.
    yamt committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    6b57624 View commit details
    Browse the repository at this point in the history