posix_spawn: Move dependencies to Kconfig

[no1wudi]

Summary

posix_spawn depends on these configurations:

• !BINFMT_DISABLE
• !DISABLE_MOUNTPOINT
• BOARDCTL
• BOARDCTL_APP_SYMTAB
• ELF
• FS_ROMFS

Check them in compile time may waste some time if the dependencies are not met, move them to Kconfig to avoid this.

Impact

No

Testing

Local machine

[nuttxpr]

[Experimental Bot, please feedback here]

Yes, this PR appears to meet the basic NuttX requirements, but it's missing some crucial information. While it provides a summary of the what and why, it lacks details on how the change is implemented.

Here's what's missing and needs to be addressed:

• Summary - How does the change exactly work? The summary mentions moving dependency checks to Kconfig, but doesn't explain how this is done. Does it involve adding new Kconfig options? Modifying existing ones? What specific changes were made to the code?

• Testing - Insufficient Detail: "Local machine" is not enough information. Provide specifics like OS, architecture, compiler, and the NuttX configuration used. Crucially, the testing logs sections are empty. You must provide logs demonstrating the behavior before and after the change to show that the change works and hasn't introduced regressions. Ideally, these logs should demonstrate the time saved during compilation.

• Impact - Potentially Incorrect: While stating "No" impact across the board is convenient, it's unlikely to be entirely accurate. Consider:

  • Impact on build: Moving checks to Kconfig will change the build process, even if subtly. This needs to be acknowledged and described, even if the impact is minimal (e.g., "Changes Kconfig dependencies for posix_spawn, resulting in faster configuration checks when dependencies are not met").
  • Impact on compatibility: While unlikely, it's possible this change could impact compatibility if existing configurations rely on the previous behavior. Thoroughly consider and document any potential edge cases.

In short, while the PR touches on the required sections, it lacks the necessary detail to be properly reviewed. Providing the missing information, particularly regarding the how of the implementation and the testing logs, will significantly improve the PR's quality and chances of acceptance.