Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app/testing:Add x86_64 abi test cases #2792

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

xianglyc
Copy link
Contributor

app/testing:Add x86_64 abi test download path

Summary

Add x86_64 abi test cases

Impact

noimpact

Testing

ostest

Signed-off-by: liwenxiang1 <[email protected]>

app/testing:Add x86_64 abi test download path

Signed-off-by: liwenxiang1 <[email protected]>
@nuttxpr
Copy link

nuttxpr commented Oct 28, 2024

[Experimental Bot, please feedback here]

No, this PR does not meet the NuttX requirements.

Missing Information:

  • Summary:
    • Lacks a clear explanation of why the change is necessary. Is it a fix, update, or new feature?
    • Needs to specify the functional part of the code being changed (e.g., which files/modules).
    • Requires a description of how the change works and what it modifies.
  • Impact:
    • The "noimpact" statement is too vague. Address each impact category specifically (user, build, hardware, documentation, security, compatibility).
  • Testing:
    • "ostest" is insufficient. Provide:
      • Details about the build host (OS, CPU, compiler).
      • Specific target information (architecture, board, configuration).
      • Relevant testing logs before and after the change, demonstrating the issue and the fix.

Recommendations:

  1. Expand the Summary to clearly articulate the purpose, functionality affected, and mechanics of the change.
  2. Thoroughly address each Impact category, explaining whether there is an impact and providing details if applicable.
  3. Provide comprehensive Testing information, including build host and target specifics, and relevant testing logs that showcase the change's effect.

@xiaoxiang781216 xiaoxiang781216 merged commit a526a4a into apache:master Oct 28, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants