-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
matter: add Kconfig option to control logging #2787
Conversation
[Experimental Bot, please feedback here] This PR summary is missing crucial information. Here's a breakdown of what's lacking and how to improve it: Summary - Missing Information
Impact - Incomplete You need to address all the points in the impact section. Even if the answer is "NO", state it explicitly. For example:
Testing - Insufficient
Revised Summary Example ## Summary
This PR addresses the issue of large log files impacting image size in NuttX. It introduces a new Kconfig option, `CONFIG_DEBUG_LOGGING`, which allows developers to enable or disable logging at compile time. This change modifies the core logging framework within the NuttX kernel ([mention specific files or modules]).
By default, `CONFIG_DEBUG_LOGGING` is set to `y` (enabled). Developers can disable logging by setting this option to `n` in their board or application configuration files.
This change provides a flexible mechanism to control logging verbosity, enabling optimization of image size for resource-constrained devices or deployments where extensive logging is not required.
## Impact
* **Is new feature added?** YES (Kconfig option for logging control - `CONFIG_DEBUG_LOGGING`)
* **Impact on user:** YES (Users can now control logging verbosity at compile time using the `CONFIG_DEBUG_LOGGING` option, potentially reducing image size).
* **Impact on build:** YES (The build system now respects the `CONFIG_DEBUG_LOGGING` option)
* **Impact on hardware:** NO
* **Impact on documentation:** YES (The documentation must be updated to explain the new `CONFIG_DEBUG_LOGGING` Kconfig option and its usage).
* **Impact on security:** YES (Disabling logging could make it more difficult to debug security issues in the field. Developers should carefully consider the security implications of disabling logs).
* **Impact on compatibility:** NO (This change does not introduce any known compatibility issues.)
## Testing
**Build Host:**
* OS: Linux Mint 21
* CPU: Intel i7-12700K
* Compiler: GCC 12.2.0
**Target:**
* QEMU simulator
* matter: [Provide a clear description of the "matter" configuration]
**Testing Logs (Before Change - Logging Enabled):**
[logs showing system behavior with logging enabled]
[logs showing system behavior with logging disabled - should be minimal or no output]
|
Logs have a great impact on image size, so whether to print logs is modified as a compilation option and controlled by Kconfig Signed-off-by: zhanghongyu <[email protected]>
Summary
Logs have a great impact on image size, so whether to print logs is modified as a compilation option and controlled by Kconfig
Impact
Testing
sim:matter