Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing/cmocka: shuffling test sequence and pass seed arg #2783

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

xiaoxiang781216
Copy link
Contributor

Summary

set CMOCKA_SHUFFLE_SEED environment variable

Impact

cmocka launcher

Testing

ci

@nuttxpr
Copy link

nuttxpr commented Oct 27, 2024

[Experimental Bot, please feedback here]

This PR appears to be missing critical information according to the NuttX requirements.

Here's what's lacking and needs clarification:

  • Summary:
    • Why is this change necessary? What problem does setting CMOCKA_SHUFFLE_SEED solve? Is it a bug fix, performance improvement, or new feature?
    • What exactly changes? How does setting this environment variable affect the cmocka launcher's behavior?
  • Impact:
    • Be specific about the impact. "cmocka launcher" is too vague. Does this affect all users of cmocka? Only specific configurations? Will existing tests behave differently?
    • Address all impact points: The template asks about build process, hardware, documentation, security, compatibility. Even if the answer is "NO," state it explicitly for each.
  • Testing:
    • "ci" is not sufficient testing information.
      • Which CI environments were used? List specific architectures and boards.
      • Provide relevant snippets of the logs demonstrating the change in behavior. What were the results before and after the change?

Recommendation:

Expand on each section with specific details. This will help reviewers understand the purpose and scope of your change, leading to a faster and smoother review process.

@GUIDINGLI GUIDINGLI merged commit 1ddeaa1 into apache:master Oct 27, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants