-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
examples/netpkt: add ethercat test example for robot #2777
Conversation
[Experimental Bot, please feedback here] The provided PR description partially meets the NuttX requirements. Here's what's good:
Here's what needs improvement:
Recommendation: Revise the PR description to address the missing information and provide more specific details. A well-structured and informative PR description increases the chances of quick review and merging. |
|
||
if (argc >= 2) | ||
{ | ||
ifname = argv[1]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assigning variable length input to const char[4] ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assigning variable length input to const char[4] ?
Is it modified like this int main(int argc, FAR const char *argv[4])
? Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why make this change? all.main should have the same prototype
int main(int argc, char *argv[]);
d894177
to
3e35d3c
Compare
add a simple example to test ethercat's sending and receiving Signed-off-by: zhanghongyu <[email protected]>
Summary
add a simple example to test ethercat's sending and receiving.
Impact
Testing
x86_64 device