Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cmake build script for math library #2774

Merged
merged 4 commits into from
Oct 27, 2024
Merged

Conversation

xiaoxiang781216
Copy link
Contributor

Summary

  • fix: git status/git status --ignore normalization check problem
  • cmake:add kissfft CMake build
  • cmake:add gemmlowp CMake build
  • cmake:add ruy CMake build

Impact

new cmake file

Testing

ci

@nuttxpr
Copy link

nuttxpr commented Oct 26, 2024

[Experimental Bot, please feedback here]

Fill In The Commit Message: This PR contains a Commit with an Empty Commit Message. Please fill in the Commit Message with the PR Summary.

No, this PR does not meet the NuttX requirements.

Missing Information:

  • Summary:
    • Lacks a clear explanation of the problem being fixed. What is the "git status/git status --ignore normalization check problem"?
    • Needs more details on how the CMake builds for kissfft, gemmlowp, and ruy are implemented and their purpose within NuttX.
  • Impact:
    • While it mentions a new CMake file, it doesn't elaborate on the impact.
    • All other impact categories are left blank, indicating a lack of consideration for potential consequences.
  • Testing:
    • Simply stating "ci" is insufficient.
    • Provide specific details about the build hosts, target architectures/boards, and the actual testing logs before and after the change.

Recommendations:

  1. Expand the Summary: Clearly articulate the issue being addressed and the implementation details of the CMake additions.
  2. Complete the Impact Section: Address all impact categories, even if the answer is "NO" with a brief justification.
  3. Provide Detailed Testing Information: List the build hosts, target environments, and include the actual testing logs before and after applying your changes.

math/gemmlowp/CMakeLists.txt Show resolved Hide resolved
math/kissfft/CMakeLists.txt Show resolved Hide resolved
math/ruy/CMakeLists.txt Show resolved Hide resolved
@GUIDINGLI GUIDINGLI merged commit f1501c5 into apache:master Oct 27, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants