Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DirectoryChooserUI button position adjustments #8105

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

mbien
Copy link
Member

@mbien mbien commented Jan 2, 2025

noticed some positioning issues while looking at the new svg icons (#8083)

Updated spacers to

  • vertically center toolbar buttons
  • fix horizontal toolbar button positions
  • fix vertical approve/cancel button positions and reduce gap

updated:
dir-chooser-pixel-improvements

NB 24:
dir-chooser-orig

(open both screenshots in separate tabs and switch between them)

Updated spacers to

 - vertically center toolbar buttons
 - fix horizontal toolbar button positions
 - fix vertical approve/cancel button positions and reduce gap
@mbien mbien added Platform [ci] enable platform tests (platform/*) UI User Interface ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Jan 2, 2025
@mbien mbien added this to the NB25 milestone Jan 2, 2025
@mbien mbien requested a review from eirikbakke January 2, 2025 02:32
Copy link
Contributor

@eirikbakke eirikbakke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for adjusting!

@mbien mbien merged commit 33cdacf into apache:master Jan 2, 2025
32 checks passed
mbien added a commit that referenced this pull request Jan 2, 2025
DirectoryChooserUI button position adjustments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Platform [ci] enable platform tests (platform/*) UI User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants