[NETBEANS-3592] Workarounds for JDK Windows LAF bugs on HiDPI screens #1777
Conversation
1) Fix tiny or huge GUI font size. 2) Fix tiny or huge UI control icons. (Workaround for JDK-8211715.) 3) Fix uneven borders on text components on non-integral HiDPI scaling factors (e.g. 150%). See JIRA issue for more details, screenshots, and a manual test plan.
eirikbakke
changed the title
|
Well for me it looks insane. In a good way of course. Thank you! |
| @@ -154,6 +154,7 @@ public static void initCustomFontSize (int uiFontSize) { | |||
| switchFont("windowTitleFont", fontTranslation, uiFontSize, nbDialogBold); // NOI18N | |||
| switchFont("Spinner.font", fontTranslation, uiFontSize, nbDialogPlain); // NOI18N | |||
| switchFont("FormattedTextField.font", fontTranslation, uiFontSize, nbDialogPlain); // NOI18N | |||
| switchFont("Slider.font", fontTranslation, uiFontSize, nbDialogPlain); // NOI18N | |||
There was a problem hiding this comment.
👍 Should add // NOI18Ns to strings of the other files that are not expected translation as well.
| private DPISafeBorder(Insets insets, Color color) { | ||
| if (insets == null) | ||
| public static Border fromDelegate(Border delegate) { | ||
| if (delegate == null) |
There was a problem hiding this comment.
Should use curly braces({}) although existing code doesn't use them.
There was a problem hiding this comment.
Well, my humble opinion is that we shall avoid throwing NullPointerExceptions directly from the code. It would be better to do an assert <whatever> != null; instead.
There was a problem hiding this comment.
Will add curly braces... I keep forgetting the code style. (The previous code was mine, too.)
Assertions can be disabled, which make them more or less useless for enforcing invariants--no way to know down the line whether they were enabled or not (e.g. when reading a log file while trying to debug an intermittent problem down the road).
There was a problem hiding this comment.
I agree - I tried to run netbeans with substance laf (or one of its siblings) and the author decided to enforce the "things interacting with GUI have to run on the EDT" rule. I ended badly (netbeans tries to do to much work off the EDT) and if Swing would have enforced the rule, netbeans could not have gone down the path in the first place. Now it is difficult to get rid of this.
The Code can be made better readable by using java.util.Objects#requireNonNull, then the missing braces will also not be a problem :-)
There was a problem hiding this comment.
Maybe, we can also use @NonNull to make "non-null" clear ? e.g. public static Border fromDelegate(@NonNull Border delegate)
There was a problem hiding this comment.
For the annotations we'd need a dependency on Common Annotations. That module causes headaches: #1764. DPISafeBorder#fromDelegate is a method, that is only called from within the module, so I would not put to much API thoughts into it.
… pixels thick. Improve JSpinner borders. Fix style.
…apache#1777) Details: 1) Fix tiny or huge GUI font size. 2) Fix tiny or huge UI control icons. (Workaround for JDK-8211715.) 3) Fix uneven borders on text components on non-integral HiDPI scaling factors (e.g. 150%). See JIRA issue for more details, screenshots, and a manual test plan.
|
I've left a link to this patch at the original JDK bug for the icon scaling issue, at https://bugs.openjdk.java.net/browse/JDK-8211715 . |
|
@eirikbakke We just saw your pull request. Do you plan on opening OpenJDK tickets for the border thickness and icon scaling bugs and provide this patch to the OpenJDK? We would like to use these bugfixes in a standard L&F for our applications. |
|
I already opened a ticket for issue 2 (icon scaling; JDK-8211715) and was working on a report for issue 3 (border widths). If you want, feel free to submit a ticket for issue 1 (font scaling). I don't have a dev environment set up to build the JDK itself, so I'm unlikely to submit JDK patches myself. Note that the workarounds here are not patches that can be applied against the JDK itself--though you can certainly copy them into your client applications. |
|
There's now an issue in the OpenJDK bug tracker concerning the "line thickness": https://bugs.openjdk.java.net/browse/JDK-8241561 |
|
@problemzebra2 Ah, great! |
Provide workarounds for various JDK bugs that caused the Windows LAF to be unusable on many HiDPI configurations, typically when an external monitor (or projector) is involved, or is disconnected or connected. Summary:
See full details on https://issues.apache.org/jira/browse/NETBEANS-3592