Updated Adobe Illustrator file for new icons in PR#8083 #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I saw nothing obviously wrong here, so from my perspective good to go. |
|
Thanks! There's another commit in this PR now to correspond with the new commit added to apache/netbeans#8083 . Once the latter is merged I can merge this PR as well. |
…s to artboard names and SVG files. Reorder some of the mappings to keep similar-looking icons together in the generated icons.html file. Icon script improvements: * Allow SVG paths to be included in mappings.tsv, for new icons that do not have a corresponding PNG or GIF file. (Did not end up using this feature currently. But it might be useful in the future.) * Permit a subset of SVG files to be copied into the NetBeans repo, depending on what files exist in the illustrator_exports folder. * Add an explanatory preamble to the generated icons.html file, with links to the README and other relevant information. * In the generated icons.html, sort unassigned bitmap icons by first path observed. (Help keeps related icons together.) This commit corresponds to the changes in apache/netbeans#8083, including the final PR revisions.
eirikbakke
force-pushed
the
pr-iconsdec24
branch
from
743265c to
28646ae
Compare
|
I squashed the commits in anticipation of merging, like in apache/netbeans#8083 |
|
Merged this one now as well as the corresponding apache/netbeans#8083 . The icon mappings committed here are thus in sync with the SVG files in the main repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the updated Adobe Illustrator file that includes the new icons added in the main NetBeans repo in apache/netbeans#8083
The file that maps bitmap icons to SVG artboard names is also updated to incorporate the new icons and identify more duplicates. See this generated page for a visual summary.
There are also some adjustments to the icon-copying script: