host/audio: move old LE Audio files to new directory #1714
Conversation
|
@MariuszSkamra PTAL |
KKopyscinski
force-pushed
the
move_audio
branch
3 times, most recently
from
5453517 to
6a63d3c
Compare
nimble/host/pkg.yml
Outdated
| pkg.deps.BLE_ISO: | ||
| - nimble/host/audio | ||
|
|
There was a problem hiding this comment.
I'm not sure I understand it correctly, this makes BLE_ISO dependent on nimble/host/audio.
If so, that does not seem right to me as you can have BLE_ISO without audio, but you cannot have audio without BLE_ISO.
There was a problem hiding this comment.
maybe we should have one common config for audio? I can add one here
apps/btshell/pkg.yml
Outdated
| @@ -35,6 +35,7 @@ pkg.deps: | |||
| - nimble/host/services/gatt | |||
| - nimble/host/store/config | |||
| - nimble/host/util | |||
| - nimble/host/audio | |||
There was a problem hiding this comment.
this seems to be ordered, thus I'd place nimble/host/audio right after nimble/host
There was a problem hiding this comment.
moved to deps of BLE_AUDIO
There was a problem hiding this comment.
dep should be added by package which defines BLE_AUDIO
KKopyscinski
force-pushed
the
move_audio
branch
2 times, most recently
from
725b726 to
32cb19b
Compare
nimble/host/audio/syscfg.yml
Outdated
| @@ -17,5 +17,8 @@ | |||
| # | |||
|
|
|||
| syscfg.defs: | |||
| BLE_AUDIO: | |||
| description: 'Indicates that a BLE Audio is present.' | |||
There was a problem hiding this comment.
I'd move this config to host/syscfg.yml, similarly where BLE_MESH is defined.
Plus, I'd suggest to describe this option like:
| description: 'Indicates that a BLE Audio is present.' | |
| description: 'This option enables Bluetooth LE Audio support.' |
Otherwise LGTM
There was a problem hiding this comment.
Fully agree :)
KKopyscinski
force-pushed
the
move_audio
branch
from
32cb19b to
e328c7c
Compare
| @@ -440,6 +440,11 @@ syscfg.defs: | |||
| that have been enabled in the stack, such as GATT support. | |||
| value: 0 | |||
|
|
|||
| BLE_AUDIO: | |||
| description: 'This option enables Bluetooth LE Audio support' | |||
| value: 0 | |||
KKopyscinski
force-pushed
the
move_audio
branch
2 times, most recently
from
746168d to
7f1df8a
Compare
|
@sjanc as discussed offline, this refactor must be single-commit, because apps won't build otherwise |
apps/btshell/pkg.yml
Outdated
| @@ -35,6 +35,7 @@ pkg.deps: | |||
| - nimble/host/services/gatt | |||
| - nimble/host/store/config | |||
| - nimble/host/util | |||
| - nimble/host/audio | |||
There was a problem hiding this comment.
dep should be added by package which defines BLE_AUDIO
This patch refactors BLE Audio library to conform to new directory tree introduced in a979570. LE Audio related files present in host/include, host/src and host/services were moved to corelated folders in host/audio. Experimental system config BLE_AUDIO enabling LE Audio feature was introduced. Naming convention for BLE Audio functions, structures and files was unified - replaced `bcst` shorthand with `broadcast`. For example, ble_audio_pub_bcst_announcement_feat was renamed to ble_audio_pub_broadcast_announcement_feat. Contents of host/include/ble_audio_common.h was incorporated into host/audio/include/audio/ble_audio.h. Apps and Auracast service were adjusted to new config and include paths. BLE_MAX_BIG and BLE_MAX_BIS renamed to BLE_ISO_MAX_BIGS and BLE_ISO_MAX_BISES, respectevaly.
LE Audio lives now in nimble/host/audio.