Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nimble/host: Fix possible overflow in ble_gatts_peer_cl_sup_feat_update #1671

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

sjanc
Copy link
Contributor

@sjanc sjanc commented Jan 2, 2024

This function would write pass conn->bhc_gatt_svr.peer_cl_sup_feat buffer. Since supported features are likely to be small (currently only 3 bits are defined) lets keep this simple and just make local copy before validation.

@sjanc sjanc requested a review from KKopyscinski January 2, 2024 16:03
@sjanc
Copy link
Contributor Author

sjanc commented Jan 2, 2024

@Roshan23699 FYI

This function would write pass conn->bhc_gatt_svr.peer_cl_sup_feat
buffer. Since supported features are likely to be small (currently
only 3 bits are defined) lets keep this simple and just make local
copy before validation.
@sjanc sjanc force-pushed the gatt_client_feat branch from e273146 to eb9c589 Compare January 3, 2024 07:50
Copy link
Contributor

@KKopyscinski KKopyscinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjanc sjanc merged commit 24a3d58 into apache:master Jan 9, 2024
16 checks passed
@sjanc sjanc deleted the gatt_client_feat branch January 9, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants