kernel/os: Fix msys unit tests #3435
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depending on optimization and compiler used unit test could
produce following error:
repos/apache-mynewt-core/kernel/os/selftest/src/msys_test.c: In function ‘os_msys_test_setup’:
repos/apache-mynewt-core/kernel/os/selftest/src/msys_test.c:61:30: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
61 | context->mempool_list = *(struct os_mempool_list *)&g_os_mempool_list;
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
This is because declaration of extern g_os_mempool_list was taken
directly from os_mempool.c where this variable is create without
specifying type with macro STAILQ_HEAD(, os_mempool) that produces:
struct {
struct os_mempool *stqh_first;
struct os_mempool **stqh_last;
} g_os_mempool_list;
while file mempool_list is same structure but with named type.
To make compiler happy g_os_mempool_list is now of type
struct os_mempool_list that has same fields and is already
declared like this:
STAILQ_HEAD(os_mempool_list, os_mempool);
Signed-off-by: Jerzy Kasenberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on optimization and compiler used unit test could produce following error:
repos/apache-mynewt-core/kernel/os/selftest/src/msys_test.c: In function ‘os_msys_test_setup’: repos/apache-mynewt-core/kernel/os/selftest/src/msys_test.c:61:30: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
61 | context->mempool_list = *(struct os_mempool_list *)&g_os_mempool_list;
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
This is because declaration of extern g_os_mempool_list was taken directly from os_mempool.c where this variable is create without specifying type with macro STAILQ_HEAD(, os_mempool) that produces:
struct {
struct os_mempool *stqh_first;
struct os_mempool **stqh_last;
} g_os_mempool_list;
while file mempool_list is same structure but with named type. To make compiler happy g_os_mempool_list is now of type struct os_mempool_list that has same fields and is already declared like this:
STAILQ_HEAD(os_mempool_list, os_mempool);