tinyusb/msc_fat_view: Small fixes #3434
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Short name generation incorrectly build file extension. For config.txt it would create 'CONFIG .TX' instead of 'CONFIG TXT' (Extra dot that should not be there) Now short name is displayed correctly Additionally typo in variable name is corrected. Signed-off-by: Jerzy Kasenberg <[email protected]>
kasjer
force-pushed
the
kasjer/msc_fat_view-root-sector-count
branch
from
375c892 to
87ca41c
Compare
One sector for root dir entry was hardcoded. It could be to small if additional entries were added. In that case firmware update could be impossible if Windows of Linux could not fit new file name in root directory. Now root director sector count is configurable in syscfg.yml by MSC_FAT_VIEW_ROOT_DIR_SECTORS Signed-off-by: Jerzy Kasenberg <[email protected]>
kasjer
force-pushed
the
kasjer/msc_fat_view-root-sector-count
branch
from
87ca41c to
1f91c79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short name generation incorrectly build file extension.
For config.txt it would create
'CONFIG .TX' instead of 'CONFIG TXT'
(Extra dot that should not be there)
Now short name is displayed correctly
Additionally typo in variable name is corrected.
Root directory sector count is not increased to 3
and configurable in syscfg.
This can prevent case when due to number of entries
in root directory host system can't write file with
updated firmware.