Improve clang-format handling for macros and enums #3432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change prevents `clang-format` from enforcing a newline after enum declarations
Refined `MacroBlockBegin` and `MacroBlockEnd` to include `STATS_SECT_START` and `STATS_SECT_END`. Removed `STATS_NAME_START` and `STATS_NAME_END` from `StatementMacros`.
sjanc
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes two formatting-related changes to
.clang-formatand supporting tooling:Fix formatting for STATS macros
Updated
MacroBlockBegin,MacroBlockEnd, andStatementMacrossettings to properly handle macro blocks likeSTATS_NAME_START/STATS_NAME_END.Disable line breaking after enums
Changed
BraceWrapping.AfterEnumtofalseto align with the existing code style and prevent unnecessary newlines after enum declarations.