Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNG-7617] Small optimisations and cleanup in the project/model building #816

Merged
merged 5 commits into from
Dec 2, 2022
Merged

[MNG-7617] Small optimisations and cleanup in the project/model building #816

merged 5 commits into from
Dec 2, 2022

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented Oct 5, 2022

Extracted from #803

@gnodet
Clean a bit DefaultProfileActivationContext
d248325 
# Conflicts:
#	maven-model-builder/src/main/java/org/apache/maven/model/profile/DefaultProfileActivationContext.java
@gnodet
Cleanup DefaultProjectBuildingResult
aa94bdc 
# Conflicts:
#	maven-core/src/main/java/org/apache/maven/project/DefaultProjectBuildingResult.java
@gnodet
Cache the injected list to avoid repetitive lookups
423fd39 
# Conflicts:
#	maven-model-builder/src/main/java/org/apache/maven/model/profile/DefaultProfileSelector.java
@gnodet
Lazily compute the MavenBuildTimestamp
eefa080 
# Conflicts:
#	maven-model-builder/src/main/java/org/apache/maven/model/interpolation/BuildTimestampValueSource.java
@gnodet
Use a single loop to select active profiles
301ee84 
# Conflicts:
#	maven-model-builder/src/main/java/org/apache/maven/model/profile/DefaultProfileSelector.java
@gnodet gnodet requested review from mthmulders and removed request for mthmulders December 2, 2022 09:18
@gnodet gnodet added this to the 4.0.0-alpha-3 milestone Dec 2, 2022
@gnodet gnodet requested a review from cstamas December 2, 2022 10:59
mthmulders
mthmulders approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@mthmulders mthmulders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last question: would we need a JIRA ticket for this?

@gnodet gnodet changed the title Small optimisations and cleanup [MNG-7617] Small optimisations and cleanup in the project/model building Dec 2, 2022
@gnodet gnodet merged commit 249c0fe into apache:master Dec 2, 2022
@gnodet gnodet deleted the speed-optim branch January 25, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mthmulders mthmulders mthmulders approved these changes

@cstamas cstamas Awaiting requested review from cstamas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0-alpha-3
Development

Successfully merging this pull request may close these issues.
2 participants
@gnodet @mthmulders