[POC] editorconfig-maven-plugin: implement IDE agnostic configuration
#2321
Conversation
Pankraz76
changed the title
editorconfig.org
|
assuming our project dont require spiked line endings like PMD and Check to pass build.
|
Pankraz76
force-pushed
the
editorconfig-maven-plugin
branch
from
17771cd to
ff92b84
Compare
Pankraz76
changed the title
editorconfig.orgeditorconfig-maven-plugin: implement IDE agnostic configuration
.editorconfig
Outdated
| root = true | ||
|
|
||
| [*] | ||
| charset = utf-8 | ||
| end_of_line = lf | ||
| indent_style = space | ||
| insert_final_newline = true | ||
|
|
||
| [*.java] | ||
| ij_continuation_indent_size = 4 | ||
| ij_java_class_count_to_use_import_on_demand = 999 | ||
| ij_java_names_count_to_use_import_on_demand = 999 | ||
| indent_size = 4 | ||
| max_line_length = 120 | ||
|
|
||
| [*.xml] | ||
| max_line_length = 160 |
There was a problem hiding this comment.
Which one is not covered by spotless or checkstyle ... do we really need next tool
There was a problem hiding this comment.
See spiked line endings. So might be yes.
Besides the broken repository file endings, wildcard imports are not covered: therefor breaking the build.
| [*.java] | ||
| ij_continuation_indent_size = 4 | ||
| ij_java_class_count_to_use_import_on_demand = 999 | ||
| ij_java_names_count_to_use_import_on_demand = 999 |
There was a problem hiding this comment.
maybe only the imports, as everything else is covered by spot.
There was a problem hiding this comment.
imports with asterix are forbidden be checkstyle
There was a problem hiding this comment.
yes but they will still happen. We need out of the box solution follow convention over config. ATM we have to config by hand this is the automat for whole world.
There was a problem hiding this comment.
intellij default is using * when having more then 5 imports. https://en.wikipedia.org/wiki/Convention_over_configuration
we have broken the contract therefore need to fix up again.
There was a problem hiding this comment.
|
|
||
| [*] | ||
| charset = utf-8 | ||
| end_of_line = lf |
There was a problem hiding this comment.
could merge without this. Try activating, then you see much files broken. preventing more. ATM dev setup seems broken, as not configured properly: https://dev.to/kevinshu/git-and-normalization-of-line-endings-228j
| end_of_line = lf | |
| #end_of_line = lf |
There was a problem hiding this comment.
need rewrite recipe for this
other stuff comes from spot and is kind of DRY only import count is real benefit.
rival/addition to
Checkstyle violations#2300rewrite-maven-plugin: Introduce OpenRewrite by Moderne #2322assuming maven project dont require spiked line endings like PMD and Check to pass build.
items:
violates insert_final_newline = trueref:
editorconfig.orgcheckstyle/checkstyle#16574