fix spelling leveraging Oxford comma

[Pankraz76]

comma after outputStream and outputStream --> output stream

#2306 (comment)

https://github.com/apache/maven/pull/2312/files#r2083278342

enabler for:

• Fix: Use correct outputStream destination; request instead of path in DefaultPluginXmlFactory#write #2312

outputStream or path must be non null evolves to ->
No valid input source given.

New sentence start with upper case, we well. Especially when talking about Oxford and articles.

but we have inconsistency already.

[Pankraz76]

[INFO] BUILD SUCCESS

[Pankraz76]

Suggested change

	throw new IllegalArgumentException("writer, output stream, or path must be non-null");
	throw new IllegalArgumentException("writer, output stream, or path must be non-null.");

missing dot. (everywhere or nowhere)

[gnodet]

That's wrong and unrelated to this PR

[Pankraz76]

Suggested change

	throw new IllegalArgumentException("writer, output stream, or path must be non-null");
	throw new IllegalArgumentException("writer, output stream, or path must be non null");

you mean the hyphen - ?

[gnodet]

No, outputStream is the parameter name, it's not output stream.
If those were common nouns, they would require an article.

[Pankraz76]

yes true. Making it generic would take random impl. details away. What if tomorrow foo resources is new input?
This is noise feeling fluffy and takes away from whats real business case.

We need some valid input - thats all.

Suggested change

	throw new IllegalArgumentException("writer, output stream, or path must be non-null");
	throw new IllegalArgumentException("No valid input source given.");

[gnodet]

But that's not helpful to the user. What does 'valid' means ?

[Pankraz76]

Yes, we could tell, as it is.

Suggested change

	throw new IllegalArgumentException("writer, output stream, or path must be non-null");
	throw new IllegalArgumentException("Given input source is null.");

[Pankraz76]

Considering OOP leveraging domain logic its kind of clear from the context now as the code should speak for itself:

ReadRequest/WriteRequest

[Pankraz76]

We should focus on communicating the actual business case rather than exposing low-level implementation details, which are likely to change.

At this stage, it’s more a matter of preference, since the code now clearly delineates each concern. Code and logging are 2 different worlds.

[Pankraz76]

this might smell, as throwing IAE but having NPE.

#2277 (comment)