Pull #2290: Modernize codebase with Java improvements - Replace custom null checks with Objects.requireNonNull
#2290
+66
−79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pankraz76
commented
May 2, 2025
impl/maven-impl/src/test/java/org/apache/maven/impl/DefaultModelXmlFactoryTest.java
Show resolved
Hide resolved
Pankraz76
changed the title
Modernize codebase with Java improvements - Replace custom null checks with Objects.requireNonNullModernize codebase with Java improvements - Replace custom null checks with Objects.requireNonNull
Pankraz76
pushed a commit
to Pankraz76/maven
that referenced
this pull request
May 2, 2025
… custom null checks with Objects.requireNonNull
elharo
approved these changes
May 5, 2025
michael-o
approved these changes
May 6, 2025
mthmulders
changed the title
Modernize codebase with Java improvements - Replace custom null checks with Objects.requireNonNullObjects.requireNonNull
olamy
requested changes
May 6, 2025
impl/maven-impl/src/main/java/org/apache/maven/impl/ImplUtils.java
Outdated
Show resolved
Hide resolved
Pankraz76
pushed a commit
to Pankraz76/maven
that referenced
this pull request
May 6, 2025
… custom null checks with Objects.requireNonNull
… custom null checks with Objects.requireNonNull
Pankraz76
commented
May 11, 2025
|
|
||
| @Named | ||
| @Singleton | ||
| public class DefaultArtifactCoordinatesFactory implements ArtifactCoordinatesFactory { | ||
| @Override | ||
| public ArtifactCoordinates create(@Nonnull ArtifactCoordinatesFactoryRequest request) { | ||
| nonNull(request, "request"); |
There was a problem hiding this comment.
this pattern is re-ocurring a lot for defensive programming. Actually the outcome is quite the same, resulting in NPE. With the only benefit of giving NullPointerException("request") instead of raw NullPointerException().
High invasive on code for little change. Why not giving dedicated abstraction layer for this? Reducing overhead to minimum, getting the message spec for free:
Pankraz76
commented
May 11, 2025
| @@ -134,7 +134,7 @@ public AbstractSession( | |||
| List<RemoteRepository> repositories, | |||
| List<org.eclipse.aether.repository.RemoteRepository> resolverRepositories, | |||
| Lookup lookup) { | |||
| this.session = nonNull(session, "session"); | |||
| this.session = requireNonNull(session, "session"); | |||
| this.repositorySystem = repositorySystem; | |||
There was a problem hiding this comment.
Kind of inconsequent. Why not this? Nullable too. Thus session not marked @NonNull so its kind of magic number?
We produce boilerplate for the only difference to have a little better error message.
This is high cost for little, to almost no, return.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull #2290: Modernize codebase with Java improvements - Replace custom null checks with
Objects.requireNonNulltoList()instead ofCollectors.toList()) #2287