Skip to content

test mimir with Jenkinsfile #2208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

test mimir with Jenkinsfile #2208

wants to merge 5 commits into from

Conversation

olamy
Copy link
Member

@olamy olamy commented Mar 31, 2025

Signed-off-by: Olivier Lamy [email protected]

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] SUMMARY,
    where you replace MNG-XXX and SUMMARY with the appropriate JIRA issue.
  • Also format the first line of the commit message like [MNG-XXX] SUMMARY.
    Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@cstamas
Copy link
Member

cstamas commented Mar 31, 2025

@olamy try to merge this one #2207

@cstamas
Copy link
Member

cstamas commented Mar 31, 2025

Also, do not copy it to .mvn (project wide) but ~/.m2/ (user wide).

@cstamas
Copy link
Member

cstamas commented Mar 31, 2025

Or just merge master, the mentioned PR is merged. But the ~/.m2/extensions.xml is still where copy should go.

@@ -67,6 +67,7 @@ def mavenBuild(jdk, extraArgs) {
withEnv(["JAVA_HOME=${tool "$jdk"}",
"PATH+MAVEN=${ tool "$jdk" }/bin:${tool "maven_3_latest"}/bin",
"MAVEN_OPTS=-Xms4G -Xmx4G -Djava.awt.headless=true"]) {
sh "cp .github/ci-extensions.xml .mvn/extensions.xml"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sh "cp .github/ci-extensions.xml .mvn/extensions.xml"
sh "cp .github/ci-extensions.xml ~/.m2/extensions.xml"

@cstamas
Copy link
Member

cstamas commented Mar 31, 2025

Oh, just spotted: with Mimir, the maven.repo.local/tail thing is not needed anymore, that was done ONLY to make sure GH cached local repo is not "polluted" with CI installed things (that needs to be installed for ITs)

@cstamas
Copy link
Member

cstamas commented Mar 31, 2025

And another Mimir change for CI #2212

@olamy
Copy link
Member Author

olamy commented Apr 3, 2025

Also, do not copy it to .mvn (project wide) but ~/.m2/ (user wide).

but it is user wide and Jenkins is sharing nodes.
is there any difference?

@olamy olamy force-pushed the jenkinsfile-mimir branch from 656e08d to 0ecf741 Compare April 3, 2025 07:05
@cstamas
Copy link
Member

cstamas commented Apr 5, 2025

but it is user wide and Jenkins is sharing nodes. is there any difference?

If shared, then yes, this place is good. GH does not share and always re-creates runners...

@olamy olamy force-pushed the jenkinsfile-mimir branch from 0ecf741 to 3c4fef4 Compare April 7, 2025 05:31
@olamy olamy force-pushed the jenkinsfile-mimir branch from fa0e037 to fbc63f3 Compare April 8, 2025 09:16
Signed-off-by: Olivier Lamy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants