-
Notifications
You must be signed in to change notification settings - Fork 2.7k
test mimir with Jenkinsfile #2208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Also, do not copy it to |
Or just merge master, the mentioned PR is merged. But the |
@@ -67,6 +67,7 @@ def mavenBuild(jdk, extraArgs) { | |||
withEnv(["JAVA_HOME=${tool "$jdk"}", | |||
"PATH+MAVEN=${ tool "$jdk" }/bin:${tool "maven_3_latest"}/bin", | |||
"MAVEN_OPTS=-Xms4G -Xmx4G -Djava.awt.headless=true"]) { | |||
sh "cp .github/ci-extensions.xml .mvn/extensions.xml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sh "cp .github/ci-extensions.xml .mvn/extensions.xml" | |
sh "cp .github/ci-extensions.xml ~/.m2/extensions.xml" |
Oh, just spotted: with Mimir, the maven.repo.local/tail thing is not needed anymore, that was done ONLY to make sure GH cached local repo is not "polluted" with CI installed things (that needs to be installed for ITs) |
And another Mimir change for CI #2212 |
but it is user wide and Jenkins is sharing nodes. |
If shared, then yes, this place is good. GH does not share and always re-creates runners... |
Signed-off-by: Olivier Lamy <[email protected]>
Signed-off-by: Olivier Lamy <[email protected]>
Signed-off-by: Olivier Lamy <[email protected]>
Signed-off-by: Olivier Lamy <[email protected]>
Signed-off-by: Olivier Lamy <[email protected]>
Signed-off-by: Olivier Lamy [email protected]
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MNG-XXX] SUMMARY
,where you replace
MNG-XXX
andSUMMARY
with the appropriate JIRA issue.[MNG-XXX] SUMMARY
.Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
mvn clean verify
to make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.