[MNG-8484] Replace BaseRequest#unmodifiable with List.copyOf() #2037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elharo
reviewed
Jan 11, 2025
api/maven-api-core/src/main/java/org/apache/maven/api/services/BaseRequest.java
Outdated
Show resolved
Hide resolved
elharo
reviewed
Jan 12, 2025
api/maven-api-core/src/main/java/org/apache/maven/api/services/BaseRequest.java
Outdated
Show resolved
Hide resolved
gnodet
force-pushed
the
copyToImmutable
branch
from
0627846 to
09cef60
Compare
gnodet
force-pushed
the
copyToImmutable
branch
from
09cef60 to
c92364e
Compare
gnodet
changed the title
elharo
approved these changes
Jan 13, 2025
elharo
changed the title
cstamas
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List.copyOf()is exactly what we need to make a defensive copy of the input collection. It also has the benefit of not doing anything if the input collection is already an immutable list.