[MNGSITE-393] Remove references to Maven 2.x #2024
Open
+7
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnodet
reviewed
Jan 7, 2025
| <code>central</code> or <code>*,!repo1</code>. | ||
| <code>*</code> (since Maven 2.0.5), <code>external:*</code> (since Maven 2.0.9) and <code>external:http:*</code> (since Maven 3.8.0) have | ||
| <code>*</code>, <code>external:*</code> and <code>external:http:*</code> (since Maven 3.8.0) have | ||
| a special meaning: see <a href="/guides/mini/guide-mirror-settings.html">Mirror Settings</a> guide. |
There was a problem hiding this comment.
Would it make sense to move the documentation in the code rather than keeping it external ?
It's easier to maintain as using a single PR allows updating both the code and the doc.
There was a problem hiding this comment.
I'm not sure what you're proposing here.
gnodet
reviewed
Jan 7, 2025
There was a problem hiding this comment.
I've seen a few other "Maven 2" references in the main model.
Would it make sense to change them as well ?
https://github.com/apache/maven/blob/master/api/maven-api-model/src/main/mdo/maven.mdo
|
Yes to remove other references, but that's for another PR. This bug has already seen dozens of PRs and may require dozens more before it;'s done. |
|
Looks like those changes are already out for review in #2023 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.