-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNG-8473] Site fixes #2010
base: master
Are you sure you want to change the base?
[MNG-8473] Site fixes #2010
Conversation
Some links like settings, toolchains and lifecycles were broken.
generate doco as well. Point all links to new doco.
Maven3 stuff should not be published
So copy paste it, but we may just kill this page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not pointing at:
maven/impl/maven-core/src/main/java/org/apache/maven/internal/impl/DefaultLifecycleRegistry.java
Lines 383 to 412 in 751d3f1
ALL, phase(VALIDATE, phase(INITIALIZE)), phase( BUILD, after(VALIDATE), phase(SOURCES), phase(RESOURCES), phase(COMPILE, after(SOURCES), dependencies(COMPILE, READY)), phase(READY, after(COMPILE), after(RESOURCES)), phase(PACKAGE, after(READY), dependencies("runtime", PACKAGE))), phase( VERIFY, after(VALIDATE), phase( UNIT_TEST, phase(TEST_SOURCES), phase(TEST_RESOURCES), phase( TEST_COMPILE, after(TEST_SOURCES), after(READY), dependencies("test-only", READY)), phase( TEST, after(TEST_COMPILE), after(TEST_RESOURCES), dependencies("test", READY))), phase(INTEGRATION_TEST)), phase(INSTALL, after(PACKAGE)), phase(DEPLOY, after(PACKAGE)))); maven/impl/maven-core/src/main/java/org/apache/maven/internal/impl/DefaultLifecycleRegistry.java
Lines 472 to 476 in 751d3f1
phase(PHASE_SITE, plugin(MAVEN_SITE_PLUGIN + "site", PHASE_SITE)), phase( PHASE_SITE_DEPLOY, after(PHASE_SITE), plugin(MAVEN_SITE_PLUGIN + "deploy", PHASE_SITE_DEPLOY))); maven/impl/maven-core/src/main/java/org/apache/maven/internal/impl/DefaultLifecycleRegistry.java
Lines 361 to 365 in 751d3f1
return List.of(phase( Phase.CLEAN, plugin( MAVEN_PLUGINS + "maven-clean-plugin:" + MAVEN_CLEAN_PLUGIN_VERSION + ":clean", Phase.CLEAN)));
They are not much readable for non developers, but maybe our target would know enough ?
The changes to the modello generation leads to unneeded processing if not building the site. That was done on purpose to simplify the config ?
re "unneeded processing": exactly, I don't care if XSD is being built but unused, what I do care about is simple POM. |
Maven4 site cleanup: make all new modules generating models also document them, expose them all and redirect all links to new documentation.
Lifecycle is the only thing missing, as it is generated on the fly, there is no more source to "point at"...
https://issues.apache.org/jira/browse/MNG-8473