[MNG-8451] Core inject depMgt for plugin resolution #2000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a change (but in implementation only!) that prevents japicmp to load up (impl) classes: ignore those, we are really interested in API only.
|
This works cool, but breaks https://issues.apache.org/jira/browse/MNG-5783 |
gnodet
reviewed
Dec 20, 2024
| .setVersion(managedDep.getArtifact().getVersion())); | ||
| } | ||
| // align scope | ||
| pluginDep = pluginDep.setScope(managedDep.getScope()); |
There was a problem hiding this comment.
Should we flag them as system scope ?
There was a problem hiding this comment.
... to avoid downloading the jars ?
There was a problem hiding this comment.
Yes, but there is more to this PR, it breaks https://issues.apache.org/jira/browse/MNG-5783 We need to implement the proposed fix in refd issue (real classpath vs ${plugin.artifacts}).
There was a problem hiding this comment.
Former contains plugin stuff + maven core imported (as one), while latter should contain all JARs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maven Core injects "own provided" artifacts when resolving plugins, instead to let the resolve and then just leave out from the classpath, this makes much less downloads happening.
Example of effects of this PR: Rebuilding Maven master with empty local repository, and after the build:
(this PR basically makes unnecessary to set "maven core dependencies to provided" anymore, as it will NOT download those unused versions, given core is providing itself instead)
Note: Maven master sports "quite fresh" (and aligned) plugins, and almost all are fixed re "provided" scope, hence this difference is not big, but it would be much more visible on some build using "higher range" of non aligned plugins.
https://issues.apache.org/jira/browse/MNG-8451