[MNG-8222] Extend PropertyContributor #1679
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add more contextual info to it. --- https://issues.apache.org/jira/browse/MNG-8222
gnodet
reviewed
Aug 23, 2024
api/maven-api-spi/src/main/java/org/apache/maven/api/spi/PropertyContributor.java
Outdated
Show resolved
Hide resolved
gnodet
reviewed
Aug 23, 2024
| for (PropertyContributor contributor : effectivePropertyContributors.values()) { | ||
| contributor.contribute(userPropertiesMap); | ||
| Map<String, String> contribution = contributor.contribute(protoSession); |
There was a problem hiding this comment.
A given contributor won't see properties added by previous contributors, is that what we want ?
gnodet
reviewed
Aug 23, 2024
| @Experimental | ||
| @ThreadSafe | ||
| public interface ProtoSession { | ||
|
|
There was a problem hiding this comment.
We should give access to CLI commands / arguments I think, this may be needed.
There was a problem hiding this comment.
Maybe just a List<String> to not expose commons-cli.
|
We will rework this, but leaving as DRAFT for reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more contextual info to it.
https://issues.apache.org/jira/browse/MNG-8222