[KYUUBI #7028] Persist the kubernetes application terminate state into metastore for app info store fallback #7029

turboFei · 2025-04-16T06:33:51Z

Why are the changes needed?

Persist the kubernetes application terminate info into metastore to prevent the event lose.
If it can not get the application info from informer application info store, fallback to get the application info from metastore instead of return NOT_FOUND directly.
It is critical because if we return false application state, it might cause data quality issue.

How was this patch tested?

UT and IT.

Was this patch authored or co-authored using generative AI tooling?

No.

codecov-commenter · 2025-04-16T08:45:45Z

Codecov Report

Attention: Patch coverage is 0% with 210 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (29b6076) to head (82ea626).
Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
...yuubi/server/metadata/jdbc/JDBCMetadataStore.scala	0.00%	140 Missing ⚠️
...kyuubi/engine/KubernetesApplicationOperation.scala	0.00%	22 Missing ⚠️
...ubi/server/metadata/jdbc/JdbcDatabaseDialect.scala	0.00%	19 Missing ⚠️
...pache/kyuubi/server/metadata/MetadataManager.scala	0.00%	17 Missing ⚠️
...ubi/server/metadata/api/KubernetesEngineInfo.scala	0.00%	12 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #7029    +/-   ##
=======================================
  Coverage    0.00%   0.00%            
=======================================
  Files         695     696     +1     
  Lines       42833   43043   +210     
  Branches     5833    5841     +8     
=======================================
- Misses      42833   43043   +210

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

turboFei · 2025-04-16T18:11:01Z

Testing passed, cc @pan3793

turboFei · 2025-04-17T23:19:09Z

This PR has been well tested. cc @pan3793

kyuubi-server/src/main/scala/org/apache/kyuubi/server/metadata/jdbc/JDBCMetadataStore.scala

kyuubi-server/src/main/resources/sql/mysql/006-KYUUBI-7028.mysql.sql

pan3793

DB schema LGTM, the upsert implementation might have improvement room

kyuubi-server/src/main/scala/org/apache/kyuubi/server/metadata/jdbc/JDBCMetadataStore.scala

migrate upsert app app name Add app name column comments

turboFei · 2025-04-25T06:54:17Z

kyuubi-server/src/main/scala/org/apache/kyuubi/server/metadata/jdbc/JdbcDatabaseDialect.scala

+         |VALUES (${colsToInsert.map(_ => "?").mkString(",")})
+         |ON CONFLICT ($keyCol)
+         |DO UPDATE SET
+         |${colsToReplace.map(c => s"$c = EXCLUDED.$c").mkString(",")}


https://www.postgresql.org/docs/current/sql-insert.html

turboFei · 2025-04-25T07:00:46Z

kyuubi-server/src/main/scala/org/apache/kyuubi/server/metadata/jdbc/JdbcDatabaseDialect.scala

+         |INSERT INTO $table (${colsToInsert.mkString(",")})
+         |VALUES (${colsToInsert.map(_ => "?").mkString(",")})
+         |ON DUPLICATE KEY UPDATE
+         |${colsToReplace.map(c => s"$c = VALUES($c)").mkString(",")}


Refer: https://dev.mysql.com/doc/refman/8.4/en/insert-on-duplicate.html

github-actions bot added the module:server label Apr 16, 2025

turboFei changed the title ~~Kubernetes state~~ [KYUUBI #7028] Persist the kubernetes application state into metastore Apr 16, 2025

turboFei changed the title ~~[KYUUBI #7028] Persist the kubernetes application state into metastore~~ [KYUUBI #7028] Persist the kubernetes application terminate state into metastore Apr 16, 2025

turboFei marked this pull request as draft April 16, 2025 06:34

turboFei force-pushed the kubernetes_state branch from 0b0700b to f761223 Compare April 16, 2025 06:51

turboFei self-assigned this Apr 16, 2025

github-actions bot added the kind:build label Apr 16, 2025

turboFei force-pushed the kubernetes_state branch 2 times, most recently from 3feec05 to d41eea6 Compare April 16, 2025 07:13

turboFei marked this pull request as ready for review April 16, 2025 07:13

turboFei changed the title ~~[KYUUBI #7028] Persist the kubernetes application terminate state into metastore~~ [KYUUBI #7028] Persist the kubernetes application terminate state into metastore for kubernetes app info fallback Apr 16, 2025

turboFei changed the title ~~[KYUUBI #7028] Persist the kubernetes application terminate state into metastore for kubernetes app info fallback~~ [KYUUBI #7028] Persist the kubernetes application terminate state into metastore for app info store fallback Apr 16, 2025

turboFei force-pushed the kubernetes_state branch from d41eea6 to b93e31d Compare April 16, 2025 17:17

turboFei mentioned this pull request Apr 16, 2025

Treat YARN/Kubernetes application NOT_FOUND as failed to prevent data quality issue #7033

Open

turboFei force-pushed the kubernetes_state branch from b93e31d to c59b079 Compare April 16, 2025 18:02

turboFei force-pushed the kubernetes_state branch 2 times, most recently from 5293f09 to fc437aa Compare April 17, 2025 02:55

turboFei requested a review from pan3793 April 17, 2025 03:22

turboFei force-pushed the kubernetes_state branch from fc437aa to 0cad265 Compare April 18, 2025 21:57

pan3793 reviewed Apr 22, 2025

View reviewed changes

kyuubi-server/src/main/scala/org/apache/kyuubi/server/metadata/jdbc/JDBCMetadataStore.scala Outdated Show resolved Hide resolved

pan3793 reviewed Apr 22, 2025

View reviewed changes

kyuubi-server/src/main/resources/sql/mysql/006-KYUUBI-7028.mysql.sql Outdated Show resolved Hide resolved

pan3793 reviewed Apr 22, 2025

View reviewed changes

kyuubi-server/src/main/resources/sql/mysql/006-KYUUBI-7028.mysql.sql Outdated Show resolved Hide resolved

pan3793 reviewed Apr 22, 2025

View reviewed changes

kyuubi-server/src/main/resources/sql/mysql/006-KYUUBI-7028.mysql.sql Outdated Show resolved Hide resolved

pan3793 reviewed Apr 23, 2025

View reviewed changes

migration

d167623

migrate upsert app app name Add app name column comments

turboFei force-pushed the kubernetes_state branch from 4177681 to d167623 Compare April 25, 2025 05:45

insert or replace

becf9d1

turboFei commented Apr 25, 2025

View reviewed changes

turboFei force-pushed the kubernetes_state branch from 99f08a4 to 57b42dd Compare April 25, 2025 07:17

do not use MYSQL deprecated VALUES(col)

12c24b1

turboFei force-pushed the kubernetes_state branch from 57b42dd to 12c24b1 Compare April 25, 2025 07:34

turboFei requested a review from pan3793 April 25, 2025 17:55

Remove create_time from k8s engine info

327a0d5

turboFei force-pushed the kubernetes_state branch from ccea4c7 to 327a0d5 Compare April 25, 2025 18:34

turboFei added 2 commits April 25, 2025 12:32

Refine

4c59beb

Add pod name

82ea626

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[KYUUBI #7028] Persist the kubernetes application terminate state into metastore for app info store fallback #7029

[KYUUBI #7028] Persist the kubernetes application terminate state into metastore for app info store fallback #7029

turboFei commented Apr 16, 2025 •

edited

Loading

codecov-commenter commented Apr 16, 2025 •

edited

Loading

turboFei commented Apr 16, 2025

turboFei commented Apr 17, 2025

pan3793 left a comment

turboFei Apr 25, 2025

turboFei Apr 25, 2025

[KYUUBI #7028] Persist the kubernetes application terminate state into metastore for app info store fallback #7029

Are you sure you want to change the base?

[KYUUBI #7028] Persist the kubernetes application terminate state into metastore for app info store fallback #7029

Conversation

turboFei commented Apr 16, 2025 • edited Loading

Why are the changes needed?

How was this patch tested?

Was this patch authored or co-authored using generative AI tooling?

codecov-commenter commented Apr 16, 2025 • edited Loading

Codecov Report

turboFei commented Apr 16, 2025

turboFei commented Apr 17, 2025

pan3793 left a comment

Choose a reason for hiding this comment

turboFei Apr 25, 2025

Choose a reason for hiding this comment

turboFei Apr 25, 2025

Choose a reason for hiding this comment

turboFei commented Apr 16, 2025 •

edited

Loading

codecov-commenter commented Apr 16, 2025 •

edited

Loading