Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spark SQL engine supports Spark 4.0 #6920

Closed
wants to merge 5 commits into from
Closed

Conversation

pan3793
Copy link
Member

@pan3793 pan3793 commented Feb 14, 2025

Why are the changes needed?

Spark 4.0 continues to receive breaking changes since 4.0.0-preview2, and the 4.0.0 RC1 is scheduled at 20250215, this PR fixes all compatibility for the latest Spark 4.0.0-SNAPSHOT for Spark SQL engine.

How was this patch tested?

Pass GHA with spark-master

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added kind:infra license, community building, project builds, asf infra related, etc. module:spark labels Feb 14, 2025
@@ -21,6 +21,10 @@ on:
schedule:
- cron: 0 4 * * *

pull_request:
branches:
- master
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will revert after passing test

@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (a5301e5) to head (170430e).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
.../spark/sql/execution/SparkSQLExecutionHelper.scala 0.00% 10 Missing ⚠️
...g/apache/spark/sql/kyuubi/SparkDatasetHelper.scala 0.00% 7 Missing ⚠️
...kyuubi/engine/spark/operation/SparkOperation.scala 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6920   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         688     689    +1     
  Lines       42592   42614   +22     
  Branches     5806    5807    +1     
======================================
- Misses      42592   42614   +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pan3793 pan3793 requested a review from cfmcgrady February 17, 2025 06:44
@pan3793 pan3793 self-assigned this Feb 17, 2025
@pan3793 pan3793 added this to the v1.9.4 milestone Feb 17, 2025
This reverts commit 75d0bf5.
@github-actions github-actions bot removed the kind:infra license, community building, project builds, asf infra related, etc. label Feb 17, 2025
@pan3793 pan3793 closed this in cc9e11c Feb 17, 2025
pan3793 added a commit that referenced this pull request Feb 17, 2025
### Why are the changes needed?

Spark 4.0 continues to receive breaking changes since 4.0.0-preview2, and the 4.0.0 RC1 is scheduled at 20250215, this PR fixes all compatibility for the latest Spark 4.0.0-SNAPSHOT for Spark SQL engine.

### How was this patch tested?

Pass GHA with `spark-master`

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #6920 from pan3793/spark4.

Closes #6920

170430e [Cheng Pan] Revert "ci"
c6d8893 [Cheng Pan] fix
86ff7ea [Cheng Pan] fix
75d0bf5 [Cheng Pan] ci
9d88c86 [Cheng Pan] fix spark 4.0 compatibility

Authored-by: Cheng Pan <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
(cherry picked from commit cc9e11c)
Signed-off-by: Cheng Pan <[email protected]>
pan3793 added a commit that referenced this pull request Feb 17, 2025
Spark 4.0 continues to receive breaking changes since 4.0.0-preview2, and the 4.0.0 RC1 is scheduled at 20250215, this PR fixes all compatibility for the latest Spark 4.0.0-SNAPSHOT for Spark SQL engine.

Pass GHA with `spark-master`

No.

Closes #6920 from pan3793/spark4.

Closes #6920

170430e [Cheng Pan] Revert "ci"
c6d8893 [Cheng Pan] fix
86ff7ea [Cheng Pan] fix
75d0bf5 [Cheng Pan] ci
9d88c86 [Cheng Pan] fix spark 4.0 compatibility

Authored-by: Cheng Pan <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
(cherry picked from commit cc9e11c)
Signed-off-by: Cheng Pan <[email protected]>
@pan3793
Copy link
Member Author

pan3793 commented Feb 17, 2025

Thanks, merged to master/1.10.2/1.9.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants