-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Scalafmt to 3.9.x #6674
Bump Scalafmt to 3.9.x #6674
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6674 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 689 689
Lines 42615 42615
Branches 5808 5808
======================================
Misses 42615 42615 ☔ View full report in Codecov by Sentry. |
I'm surprised that |
I agree. This PR is more about a demonstration for the impact of |
d27d81b
to
762daab
Compare
07eb6eb
to
c50db64
Compare
0b1ba09
to
ad5ea8e
Compare
Hi @pan3793 , I've reopened this PR and it should be ready for merge. |
ad5ea8e
to
c302ffc
Compare
c302ffc
to
d9f4f9d
Compare
This PR is bringing less impact than previouly expected in earyly version of 3.8.x, and it's ready to go. WDYT? @pan3793 |
prettifier: Prettifier, | ||
pos: Position): Unit = { | ||
splitFirstExpectedLine: Boolean = | ||
false)(implicit prettifier: Prettifier, pos: Position): Unit = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
too weird style ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Maybe we would find another way or config to get rid of it in the future. We are modernizing the config name into binPack.importSelectors
this time.
🔍 Description
Issue References 🔗
This pull request fixes #
Describe Your Solution 🔧
Without this PR:
With this PR:
binPack.importSelectors=singleLine
, minimizing the impacts to existed codeTypes of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklist 📝
Be nice. Be informative.