[KYUUBI #3359] Minor change LdapAuthenticationProviderImpl to adapt AD #3359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compatible with the Microsoft Active Directory LDAP
Could please provide more details about the error? e.g. the exception stacktrace |
pan3793
changed the title
|
#4152 fully ported LDAP-related functionalities from Apache Hive, it supposes to support Active Directory, would you please help to verify it? |
|
Thanks for the PR! This PR is being closed due to inactivity. This isn't a judgement on the merit of the PR in any way. If this is still an issue with the latest version of Kyuubi, please reopen it and ask a committer to remove the Stale tag! Thank you for using Kyuubi! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compatible with the Microsoft Active Directory LDAP.
Currently, Apache Kyuubi support open LDAP, cannot support Microsoft Active Directory LDAP,I try much more times, So
I try to debug LdapAuthenticationProviderImpl class,I find something wrong with use Active Directory LDAP to connect to kyuubi authorized.it can be connect ,but close connect have something wrong,so I clear the close method,it can be very well。support Active Directory LDAP。
Why are the changes needed?
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request